From: David Turner <dturner@twopensource.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, pclouds@gmail.com,
Ramsay Jones <ramsay@ramsayjones.plus.com>
Subject: Re: [PATCH v5 03/15] index-helper: new daemon for caching index and related stuff
Date: Wed, 20 Apr 2016 15:38:57 -0400 [thread overview]
Message-ID: <1461181137.5540.167.camel@twopensource.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1604201349590.2826@virtualbox>
On Wed, 2016-04-20 at 14:17 +0200, Johannes Schindelin wrote:
> Hi Dave,
>
> (apologies in advance if I may bring up anything that has been
> discussed
> in earlier iterations; I simply was too busy with the rebase--helper
> project to even look.)
>
> On Tue, 19 Apr 2016, David Turner wrote:
>
> > Shared memory is done by storing files in a per-repository
> > temporary
> > directory. This is more portable than shm (which requires
> > posix-realtime and has various quirks on OS X). It might even work
> > on
> > Windows, although this has not been tested. The shared memory
> > file's
> > name folows the template "shm-<object>-<SHA1>" where <SHA1> is the
>
> s/folows/follows/
Will fix, thanks.
> And: now that it is no longer shared memory, should we not do away
> with
> the "shm-" prefix?
Hm. It's intended to be shared via MAP_SHARED. So it is just a "disk
-backed" shared memory object instead of a POSIX shm object.
> > + if (*new_mmap == MAP_FAILED) {
> > + *new_mmap = NULL;
> > + goto done;
>
> Shouldn't we provide some sort of error message here?
We generally try to fail silently on index-helper failures -- the user
isn't necessarily expecting output at that point, and we can always
fall back to directly reading the index.
On the other hand, this error should pretty much never happen, so maybe
it's worth calling out?
next prev parent reply other threads:[~2016-04-20 19:39 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 23:27 [PATCH v5 00/15] index-helper/watchman David Turner
2016-04-19 23:27 ` [PATCH v5 01/15] read-cache.c: fix constness of verify_hdr() David Turner
2016-04-19 23:27 ` [PATCH v5 02/15] read-cache: allow to keep mmap'd memory after reading David Turner
2016-04-20 9:01 ` Johannes Schindelin
2016-04-20 19:41 ` David Turner
2016-04-20 9:26 ` Duy Nguyen
2016-04-20 19:43 ` David Turner
2016-04-19 23:27 ` [PATCH v5 03/15] index-helper: new daemon for caching index and related stuff David Turner
2016-04-20 12:17 ` Johannes Schindelin
2016-04-20 12:31 ` Duy Nguyen
2016-04-20 19:38 ` David Turner [this message]
2016-04-19 23:27 ` [PATCH v5 04/15] index-helper: add --strict David Turner
2016-04-19 23:27 ` [PATCH v5 05/15] daemonize(): set a flag before exiting the main process David Turner
2016-04-19 23:28 ` [PATCH v5 06/15] index-helper: add --detach David Turner
2016-04-19 23:50 ` Duy Nguyen
2016-04-20 1:04 ` David Turner
2016-04-20 9:33 ` Duy Nguyen
2016-04-25 20:53 ` David Turner
2016-04-19 23:28 ` [PATCH v5 07/15] read-cache: add watchman 'WAMA' extension David Turner
2016-04-19 23:28 ` [PATCH v5 08/15] Add watchman support to reduce index refresh cost David Turner
2016-04-19 23:28 ` [PATCH v5 09/15] index-helper: use watchman to avoid refreshing index with lstat() David Turner
2016-04-20 0:15 ` Duy Nguyen
2016-04-20 1:01 ` David Turner
2016-04-20 9:36 ` Duy Nguyen
2016-04-19 23:28 ` [PATCH v5 10/15] update-index: enable/disable watchman support David Turner
2016-04-19 23:45 ` Duy Nguyen
2016-04-20 19:50 ` David Turner
2016-04-19 23:28 ` [PATCH v5 11/15] unpack-trees: preserve index extensions David Turner
2016-04-19 23:28 ` [PATCH v5 12/15] index-helper: kill mode David Turner
2016-04-19 23:28 ` [PATCH v5 13/15] index-helper: don't run if already running David Turner
2016-04-19 23:28 ` [PATCH v5 14/15] index-helper: autorun mode David Turner
2016-04-19 23:28 ` [PATCH v5 15/15] index-helper: optionally automatically run David Turner
2016-04-20 9:59 ` [PATCH 16/15] Add tracing to measure where most of the time is spent Nguyễn Thái Ngọc Duy
2016-04-20 12:28 ` Johannes Schindelin
2016-04-20 12:36 ` Duy Nguyen
-- strict thread matches above, loose matches on Subject: below --
2016-04-20 0:31 [PATCH v5 03/15] index-helper: new daemon for caching index and related stuff Duy Nguyen
2016-04-20 0:44 ` David Turner
2016-04-20 12:19 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461181137.5540.167.camel@twopensource.com \
--to=dturner@twopensource.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).