From: Pranit Bauva <pranit.bauva@gmail.com>
To: git@vger.kernel.org
Cc: sunshine@sunshineco.com, gitster@pobox.com,
Pranit Bauva <pranit.bauva@gmail.com>
Subject: [PATCH v15 2/7] test-parse-options: print quiet as integer
Date: Sun, 1 May 2016 01:33:31 +0530 [thread overview]
Message-ID: <1462046616-2582-2-git-send-email-pranit.bauva@gmail.com> (raw)
In-Reply-To: <1462046616-2582-1-git-send-email-pranit.bauva@gmail.com>
We would want to see how multiple --quiet options affect the value of
the underlying variable (we may want "--quiet --quiet" to still be 1, or
we may want to see the value incremented to 2). Show the value as
integer to allow us to inspect it.
Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
---
t/t0040-parse-options.sh | 26 +++++++++++++-------------
test-parse-options.c | 2 +-
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/t/t0040-parse-options.sh b/t/t0040-parse-options.sh
index 477fcff..450da45 100755
--- a/t/t0040-parse-options.sh
+++ b/t/t0040-parse-options.sh
@@ -64,7 +64,7 @@ timestamp: 0
string: (not set)
abbrev: 7
verbose: 0
-quiet: no
+quiet: 0
dry run: no
file: (not set)
EOF
@@ -164,7 +164,7 @@ timestamp: 0
string: 123
abbrev: 7
verbose: 2
-quiet: no
+quiet: 0
dry run: yes
file: prefix/my.file
EOF
@@ -184,7 +184,7 @@ timestamp: 0
string: 321
abbrev: 10
verbose: 2
-quiet: no
+quiet: 0
dry run: no
file: prefix/fi.le
EOF
@@ -212,7 +212,7 @@ timestamp: 0
string: 123
abbrev: 7
verbose: 0
-quiet: no
+quiet: 0
dry run: no
file: (not set)
arg 00: a1
@@ -235,7 +235,7 @@ timestamp: 0
string: (not set)
abbrev: 7
verbose: 0
-quiet: no
+quiet: 0
dry run: no
file: (not set)
EOF
@@ -264,7 +264,7 @@ timestamp: 0
string: 123
abbrev: 7
verbose: 0
-quiet: no
+quiet: 0
dry run: no
file: (not set)
EOF
@@ -303,7 +303,7 @@ timestamp: 0
string: (not set)
abbrev: 7
verbose: 0
-quiet: no
+quiet: 0
dry run: no
file: (not set)
arg 00: --quux
@@ -323,7 +323,7 @@ timestamp: 1
string: (not set)
abbrev: 7
verbose: 0
-quiet: yes
+quiet: 1
dry run: no
file: (not set)
arg 00: foo
@@ -345,7 +345,7 @@ timestamp: 0
string: (not set)
abbrev: 7
verbose: 0
-quiet: no
+quiet: 0
dry run: no
file: (not set)
EOF
@@ -374,7 +374,7 @@ timestamp: 0
string: (not set)
abbrev: 7
verbose: 0
-quiet: no
+quiet: 0
dry run: no
file: (not set)
EOF
@@ -399,7 +399,7 @@ timestamp: 0
string: (not set)
abbrev: 7
verbose: 0
-quiet: no
+quiet: 0
dry run: no
file: (not set)
EOF
@@ -430,7 +430,7 @@ timestamp: 0
string: (not set)
abbrev: 7
verbose: 0
-quiet: no
+quiet: 0
dry run: no
file: (not set)
EOF
@@ -449,7 +449,7 @@ timestamp: 0
string: (not set)
abbrev: 7
verbose: 0
-quiet: no
+quiet: 0
dry run: no
file: (not set)
EOF
diff --git a/test-parse-options.c b/test-parse-options.c
index 2c8c8f1..86afa98 100644
--- a/test-parse-options.c
+++ b/test-parse-options.c
@@ -90,7 +90,7 @@ int main(int argc, char **argv)
printf("string: %s\n", string ? string : "(not set)");
printf("abbrev: %d\n", abbrev);
printf("verbose: %d\n", verbose);
- printf("quiet: %s\n", quiet ? "yes" : "no");
+ printf("quiet: %d\n", quiet);
printf("dry run: %s\n", dry_run ? "yes" : "no");
printf("file: %s\n", file ? file : "(not set)");
--
2.8.1
next prev parent reply other threads:[~2016-04-30 20:04 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-30 20:03 [PATCH v15 1/7] t0040-test-parse-options.sh: fix style issues Pranit Bauva
2016-04-30 20:03 ` Pranit Bauva [this message]
2016-04-30 20:03 ` [PATCH v15 3/7] t0040-parse-options: improve test coverage Pranit Bauva
2016-05-04 8:36 ` Eric Sunshine
2016-05-05 4:46 ` Pranit Bauva
2016-04-30 20:03 ` [PATCH v15 4/7] parse-options.c: make OPTION_COUNTUP respect "unspecified" values Pranit Bauva
2016-04-30 20:03 ` [PATCH v15 5/7] t7507-commit-verbose: improve test coverage by testing number of diffs Pranit Bauva
2016-04-30 20:03 ` [PATCH v15 6/7] commit: add a commit.verbose config variable Pranit Bauva
2016-04-30 20:03 ` [PATCH v15 7/7] t/t7507: tests for broken behavior of status Pranit Bauva
2016-05-02 23:07 ` Junio C Hamano
2016-05-03 3:39 ` Pranit Bauva
2016-05-03 5:12 ` Eric Sunshine
2016-05-03 6:42 ` Pranit Bauva
2016-05-03 6:49 ` Eric Sunshine
2016-05-03 9:18 ` Pranit Bauva
2016-05-03 16:17 ` Eric Sunshine
2016-05-03 16:18 ` Pranit Bauva
2016-05-03 15:47 ` Junio C Hamano
2016-05-05 9:49 ` [PATCH v16 0/7] config commit verbose Pranit Bauva
2016-05-05 9:49 ` [PATCH v16 1/7] t0040-test-parse-options.sh: fix style issues Pranit Bauva
2016-05-05 9:49 ` [PATCH v16 2/7] test-parse-options: print quiet as integer Pranit Bauva
2016-05-05 9:49 ` [PATCH v16 3/7] t0040-parse-options: improve test coverage Pranit Bauva
2016-05-05 9:49 ` [PATCH v16 4/7] t/t7507: " Pranit Bauva
2016-05-05 9:50 ` [PATCH v16 5/7] parse-options.c: make OPTION_COUNTUP respect "unspecified" values Pranit Bauva
2016-05-05 9:50 ` [PATCH v16 6/7] t7507-commit-verbose: improve test coverage by testing number of diffs Pranit Bauva
2016-05-05 9:50 ` [PATCH v16 7/7] commit: add a commit.verbose config variable Pranit Bauva
2016-05-05 19:14 ` Junio C Hamano
2016-05-06 5:05 ` Pranit Bauva
2016-05-06 6:40 ` Pranit Bauva
2016-05-06 5:07 ` Eric Sunshine
2016-05-05 19:21 ` [PATCH v16 0/7] config commit verbose Junio C Hamano
2016-05-05 21:50 ` [PATCH 0/3] test-parse-options update Junio C Hamano
2016-05-05 21:50 ` [PATCH 1/3] test-parse-options: fix output when callback option fails Junio C Hamano
2016-05-05 21:50 ` [PATCH 2/3] test-parse-options: hold output in a strbuf Junio C Hamano
2016-05-05 21:50 ` [PATCH 3/3] test-parse-options: --expect=<string> option to simplify tests Junio C Hamano
2016-05-06 0:41 ` Stefan Beller
2016-05-06 1:27 ` Eric Sunshine
2016-05-06 2:57 ` Junio C Hamano
2016-05-06 5:51 ` Stefan Beller
2016-05-06 7:18 ` Junio C Hamano
2016-05-06 17:34 ` Junio C Hamano
2016-05-06 18:00 ` [PATCH] t0040: remove unused test helpers Junio C Hamano
2016-05-06 5:30 ` [PATCH v16 0/7] config commit verbose Eric Sunshine
2016-05-06 14:20 ` SZEDER Gábor
2016-05-06 15:33 ` Junio C Hamano
2016-05-07 5:32 ` Jeff King
2016-05-07 19:28 ` Ævar Arnfjörð Bjarmason
2016-05-08 18:48 ` Junio C Hamano
2016-05-09 14:28 ` Jeff King
2016-05-09 16:01 ` Junio C Hamano
[not found] ` <CACBZZX5ssO2EiuxR7wotGowMaPhtioaJVSDpQDUwUkv1rLJJWw@mail.gmail.com>
2016-05-06 16:16 ` Pranit Bauva
2016-05-06 19:47 ` Ævar Arnfjörð Bjarmason
2016-05-06 20:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462046616-2582-2-git-send-email-pranit.bauva@gmail.com \
--to=pranit.bauva@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).