From: Philip Oakley <philipoakley@iee.org>
To: GitList <git@vger.kernel.org>, Self <philipoakley@iee.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
git-for-windows <git-for-windows@googlegroups.com>
Subject: [PATCH] Conflicting PREFIX usage
Date: Thu, 5 May 2016 22:28:52 +0100 [thread overview]
Message-ID: <1462483733-3496-1-git-send-email-philipoakley@iee.org> (raw)
While trying to resurrect the MSVC/Visual Studio capability for Git
for Windows I noticed this little nuance.
The PREFIX in Windows was introduced in 35fb0e8 (Compute prefix at runtime
if RUNTIME_PREFIX is set, 2009-01-18) and in sideband.c at ebe8fa7
(fix display overlap between remote and local progress, 2007-11-04) though
clash has not been noticed before.
The attached patch simply gives the two PREFIXs more purposeful names of
EXEC_PREFIX and DISPLAY_PREFIX.
Philip Oakley (1):
exec_cmd.c, sideband.c, Makefile: avoid multiple PREFIX definitions
Makefile | 2 +-
exec_cmd.c | 4 ++--
sideband.c | 6 +++---
3 files changed, 6 insertions(+), 6 deletions(-)
--
2.8.1.windows.1
next reply other threads:[~2016-05-05 21:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 21:28 Philip Oakley [this message]
2016-05-05 21:28 ` [PATCH] exec_cmd.c, sideband.c, Makefile: avoid multiple PREFIX definitions Philip Oakley
2016-05-05 22:02 ` Junio C Hamano
2016-05-06 7:23 ` Philip Oakley
2016-05-06 16:55 ` Junio C Hamano
2016-05-06 6:18 ` [git-for-windows] " Johannes Sixt
2016-05-06 7:31 ` Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462483733-3496-1-git-send-email-philipoakley@iee.org \
--to=philipoakley@iee.org \
--cc=git-for-windows@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).