* [PATCH] t: fix duplicate words of "output"
@ 2016-05-06 12:22 Li Peng
2016-05-06 17:26 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Li Peng @ 2016-05-06 12:22 UTC (permalink / raw)
To: git; +Cc: ilya.bobyr, Li Peng
Fix duplicate words of "output" in comment.
Signed-off-by: Li Peng <lip@dtdream.com>
---
t/t0000-basic.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
index 79b9074..60811a3 100755
--- a/t/t0000-basic.sh
+++ b/t/t0000-basic.sh
@@ -98,7 +98,7 @@ check_sub_test_lib_test () {
}
check_sub_test_lib_test_err () {
- name="$1" # stdin is the expected output output from the test
+ name="$1" # stdin is the expected output from the test
# expected error output is in descriptior 3
(
cd "$name" &&
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] t: fix duplicate words of "output"
2016-05-06 12:22 [PATCH] t: fix duplicate words of "output" Li Peng
@ 2016-05-06 17:26 ` Junio C Hamano
2016-05-07 0:15 ` Ilya Bobyr
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2016-05-06 17:26 UTC (permalink / raw)
To: Li Peng; +Cc: git, ilya.bobyr
Li Peng <lip@dtdream.com> writes:
> Fix duplicate words of "output" in comment.
>
> Signed-off-by: Li Peng <lip@dtdream.com>
> ---
> t/t0000-basic.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
> index 79b9074..60811a3 100755
> --- a/t/t0000-basic.sh
> +++ b/t/t0000-basic.sh
> @@ -98,7 +98,7 @@ check_sub_test_lib_test () {
> }
>
> check_sub_test_lib_test_err () {
> - name="$1" # stdin is the expected output output from the test
> + name="$1" # stdin is the expected output from the test
The original is marginally correct. The first "output" is a noun,
"expected output", the second one is a pp of verb "to output",
i.e. "to produce".
I would have written it as "the expected output produced by the
test", though.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] t: fix duplicate words of "output"
2016-05-06 17:26 ` Junio C Hamano
@ 2016-05-07 0:15 ` Ilya Bobyr
0 siblings, 0 replies; 3+ messages in thread
From: Ilya Bobyr @ 2016-05-07 0:15 UTC (permalink / raw)
To: Junio C Hamano, Li Peng; +Cc: git
On 5/6/2016 10:26 AM, Junio C Hamano wrote:
> Li Peng <lip@dtdream.com> writes:
>
>> Fix duplicate words of "output" in comment.
>>
>> Signed-off-by: Li Peng <lip@dtdream.com>
>> ---
>> t/t0000-basic.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
>> index 79b9074..60811a3 100755
>> --- a/t/t0000-basic.sh
>> +++ b/t/t0000-basic.sh
>> @@ -98,7 +98,7 @@ check_sub_test_lib_test () {
>> }
>>
>> check_sub_test_lib_test_err () {
>> - name="$1" # stdin is the expected output output from the test
>> + name="$1" # stdin is the expected output from the test
> The original is marginally correct. The first "output" is a noun,
> "expected output", the second one is a pp of verb "to output",
> i.e. "to produce".
>
> I would have written it as "the expected output produced by the
> test", though.
Right, the original form is quite hard to understand %)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-07 0:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-06 12:22 [PATCH] t: fix duplicate words of "output" Li Peng
2016-05-06 17:26 ` Junio C Hamano
2016-05-07 0:15 ` Ilya Bobyr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).