* t5601-clone.sh failures
@ 2016-05-09 17:10 Armin Kunaschik
2016-05-09 17:53 ` [PATCH v1 1/1] t5601: Remove trailing space in sed expression tboegi
0 siblings, 1 reply; 3+ messages in thread
From: Armin Kunaschik @ 2016-05-09 17:10 UTC (permalink / raw)
To: Git List
Hi list,
eight t5601 tests don't run with my version of sed.
The reason is a trailing space in the sed expression. See below:
#IPv6
for tuah in ::1 [::1] [::1]: user@::1 user@[::1] user@[::1]:
[user@::1] [user@::1]:
do
ehost=$(echo $tuah | sed -e "s/1]:/1]/ "| tr -d "[]")
test_expect_success "clone ssh://$tuah/home/user/repo" "
test_clone_url ssh://$tuah/home/user/repo $ehost /home/user/repo
"
done
I can not imagine a reason why there should be a space character...
The tests run fine here without the space.
When there isn't any reason, the trailing space should be removed.
Armin
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v1 1/1] t5601: Remove trailing space in sed expression
2016-05-09 17:10 t5601-clone.sh failures Armin Kunaschik
@ 2016-05-09 17:53 ` tboegi
2016-05-09 18:38 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: tboegi @ 2016-05-09 17:53 UTC (permalink / raw)
To: git; +Cc: megabreit, Torsten Bögershausen
From: Torsten Bögershausen <tboegi@web.de>
The sed expression for IPv6, "Tested User And Host" or "tuah" used a wrong
sed expression, which doesn't work under all versions of sed.
Reported-By: Armin Kunaschik <megabreit@googlemail.com>
Signed-off-by: Torsten Bögershausen <tboegi@web.de>
---
t/t5601-clone.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh
index 150aeaf..a433394 100755
--- a/t/t5601-clone.sh
+++ b/t/t5601-clone.sh
@@ -466,7 +466,7 @@ test_expect_success 'clone ssh://host.xz:22/~repo' '
#IPv6
for tuah in ::1 [::1] [::1]: user@::1 user@[::1] user@[::1]: [user@::1] [user@::1]:
do
- ehost=$(echo $tuah | sed -e "s/1]:/1]/ "| tr -d "[]")
+ ehost=$(echo $tuah | sed -e "s/1]:/1]/" | tr -d "[]")
test_expect_success "clone ssh://$tuah/home/user/repo" "
test_clone_url ssh://$tuah/home/user/repo $ehost /home/user/repo
"
--
2.0.0.rc1.6318.g0c2c796
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] t5601: Remove trailing space in sed expression
2016-05-09 17:53 ` [PATCH v1 1/1] t5601: Remove trailing space in sed expression tboegi
@ 2016-05-09 18:38 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2016-05-09 18:38 UTC (permalink / raw)
To: tboegi; +Cc: git, megabreit
tboegi@web.de writes:
> From: Torsten Bögershausen <tboegi@web.de>
>
> The sed expression for IPv6, "Tested User And Host" or "tuah" used a wrong
> sed expression, which doesn't work under all versions of sed.
>
> Reported-By: Armin Kunaschik <megabreit@googlemail.com>
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
> ---
Good. Thanks.
> t/t5601-clone.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh
> index 150aeaf..a433394 100755
> --- a/t/t5601-clone.sh
> +++ b/t/t5601-clone.sh
> @@ -466,7 +466,7 @@ test_expect_success 'clone ssh://host.xz:22/~repo' '
> #IPv6
> for tuah in ::1 [::1] [::1]: user@::1 user@[::1] user@[::1]: [user@::1] [user@::1]:
> do
> - ehost=$(echo $tuah | sed -e "s/1]:/1]/ "| tr -d "[]")
> + ehost=$(echo $tuah | sed -e "s/1]:/1]/" | tr -d "[]")
> test_expect_success "clone ssh://$tuah/home/user/repo" "
> test_clone_url ssh://$tuah/home/user/repo $ehost /home/user/repo
> "
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-09 18:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-09 17:10 t5601-clone.sh failures Armin Kunaschik
2016-05-09 17:53 ` [PATCH v1 1/1] t5601: Remove trailing space in sed expression tboegi
2016-05-09 18:38 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).