From: David Turner <dturner@twopensource.com>
To: Stefan Beller <sbeller@google.com>, jrnieder@gmail.com
Cc: git@vger.kernel.org
Subject: Re: [RFD PATCH 0/3] Free all the memory!
Date: Tue, 17 May 2016 01:46:46 -0400 [thread overview]
Message-ID: <1463464006.24478.71.camel@twopensource.com> (raw)
In-Reply-To: <20160517032247.25092-1-sbeller@google.com>
On Mon, 2016-05-16 at 20:22 -0700, Stefan Beller wrote:
> When using automated tools to find memory leaks, it is hard to
> distinguish
> between actual leaks and intentional non-cleanups at the end of the
> program,
> such that the actual leaks hide in the noise.
valgrind on git rev-parse HEAD shows:
==21785== definitely lost: 153
bytes in 2 blocks
==21785== indirectly lost: 0 bytes in 0 blocks
==217
85== possibly lost: 0 bytes in 0 blocks
==21785== still
reachable: 58,635 bytes in 570 blocks
==21785== suppressed: 0
bytes in 0 blocks
AFAIK, nothing in the "definitely lost" category is fixed by your rev-parse patch.
I don't think we care that much about "still reachable" memory -- I only care about lost memory. I could imagine, I guess, something that happens to save a pointer to a bunch of memory that should be freed, but I don't think that's the common case.
Unless, I guess, you're planning on making a library out of git. Then it would be worth doing much more cleanup.
next prev parent reply other threads:[~2016-05-17 5:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 3:22 [RFD PATCH 0/3] Free all the memory! Stefan Beller
2016-05-17 3:22 ` [PATCH 1/3] mv: free memory at the end if desired Stefan Beller
2016-05-17 4:14 ` Torsten Bögershausen
2016-05-17 3:22 ` [PATCH 2/3] pack-redundant: free all memory Stefan Beller
2016-05-17 3:42 ` Eric Sunshine
2016-05-17 3:22 ` [PATCH 3/3] rev-parse: " Stefan Beller
2016-05-17 3:41 ` [RFD PATCH 0/3] Free all the memory! Eric Sunshine
2016-05-17 12:08 ` Eric Wong
2016-05-17 17:58 ` Stefan Beller
2016-05-17 18:16 ` Junio C Hamano
2016-05-17 18:20 ` Stefan Beller
2016-05-18 7:23 ` Eric Wong
2016-05-18 15:19 ` Ævar Arnfjörð Bjarmason
2016-05-17 5:46 ` David Turner [this message]
2016-05-17 9:05 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463464006.24478.71.camel@twopensource.com \
--to=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).