From: Andrew Oakley <aoakley@roku.com>
To: <git@vger.kernel.org>
Cc: <gitster@pobox.com>, <larsxschneider@gmail.com>,
<luke@diamand.org>, Andrew Oakley <aoakley@roku.com>
Subject: [PATCH 1/1] git-p4: correct hasBranchPrefix verbose output
Date: Wed, 22 Jun 2016 10:26:11 +0100 [thread overview]
Message-ID: <1466587571-18532-1-git-send-email-aoakley@roku.com> (raw)
In-Reply-To: <xmqqbn2uqufj.fsf@gitster.mtv.corp.google.com>
The logic here was inverted, you got a message saying the file is
ignored for each file that is not ignored.
Signed-off-by: Andrew Oakley <aoakley@roku.com>
---
git-p4.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-p4.py b/git-p4.py
index b6593cf..b123aa2 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -2674,7 +2674,7 @@ class P4Sync(Command, P4UserMap):
return True
hasPrefix = [p for p in self.branchPrefixes
if p4PathStartsWith(path, p)]
- if hasPrefix and self.verbose:
+ if not hasPrefix and self.verbose:
print('Ignoring file outside of prefix: {0}'.format(path))
return hasPrefix
--
2.7.3
next prev parent reply other threads:[~2016-06-22 11:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 13:53 [PATCH 1/1] git-p4: correct hasBranchPrefix verbose output Andrew Oakley
2016-06-21 18:05 ` Lars Schneider
2016-06-21 18:16 ` Junio C Hamano
2016-06-22 9:24 ` Andrew Oakley
2016-06-22 9:26 ` Andrew Oakley [this message]
2016-06-22 18:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466587571-18532-1-git-send-email-aoakley@roku.com \
--to=aoakley@roku.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
--cc=luke@diamand.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).