From: Joe Perches <joe@perches.com>
To: git <git@vger.kernel.org>
Subject: git am and duplicate signatures
Date: Tue, 30 Aug 2016 09:12:36 -0700 [thread overview]
Message-ID: <1472573556.5512.93.camel@perches.com> (raw)
git-am -s will avoid duplicating the last signature
in a patch.
But given a developer creates a patch, send it around for
acks/other signoffs, collects signatures and then does
a git am -s on a different branch, this sort of sign-off
chain is possible:
Signed-off-by: Original Developer <od@domain.com>
Acked-by: Random Developer <rd@domain.com>
Signed-off-by: Original Developer <od@domain.com>
Should there be an option to avoid duplicate signatures
in a sequence where an author can git-am the same patch?
sequencer.c:append_signoff() has a flag for APPEND_SIGNOFF_DEDUP
sequencer.c:void append_signoff(struct strbuf *msgbuf, int ignore_footer, unsigned flag)
but
builtin/commit.c: append_signoff(&sb, ignore_non_trailer(&sb), 0);
doesn't have an optional use mechanism available.
next reply other threads:[~2016-08-30 16:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 16:12 Joe Perches [this message]
2016-08-30 16:54 ` git am and duplicate signatures Junio C Hamano
2016-08-30 17:07 ` Joe Perches
2016-08-30 17:37 ` Junio C Hamano
2016-08-30 17:26 ` Joe Perches
2016-08-30 17:34 ` Junio C Hamano
2016-08-30 17:41 ` Joe Perches
2016-08-30 17:49 ` Joe Perches
2016-08-30 18:17 ` Junio C Hamano
2016-08-30 18:21 ` Joe Perches
2016-08-30 19:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472573556.5512.93.camel@perches.com \
--to=joe@perches.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).