git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] git-send-email: Add ability to cc: any "bylines" in the commit message
Date: Wed, 31 Aug 2016 12:39:04 -0700	[thread overview]
Message-ID: <1472672344.4176.32.camel@perches.com> (raw)
In-Reply-To: <xmqq4m6020nh.fsf@gitster.mtv.corp.google.com>

On Wed, 2016-08-31 at 12:34 -0700, Junio C Hamano wrote:
> Joe Perches <joe@perches.com> writes:
> > Many commits have various forms of bylines similar to
> A missing blank line (I can tweak while queuing).
[]
> > +				next if $suppress_cc{'bylines'} and $what !~ /Signed-off-by/i and $what =~ /by$/i;
> Having to keep this /by$/i in sync with whatever definition of
> bylines is will be error prone.  How about doing it in this way?
> 
> 	# Now parse the message body
> +	my $bypat = r/[\w-]+-by/;
> 	while (<$fh>) {
>         	...
>                 if (/^(Signed-off-by|Cc|$bypat): (.*)$/i) {
>                 	...
>                         	next if $suppress_cc{'bodycc'} and $what =~ /Cc/i;
> +				next if $suppress_cc{'bylines'} and
> +					$what !~ /^Signed-off-by/i and
> +					$what =~ /^$bypat/i;
> 
> Other than that, looking good.

Sure, whatever you want, do you want a v3 from me or can
you fix it up however you want?


  reply	other threads:[~2016-08-31 19:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-31 18:51 [PATCH V2] git-send-email: Add ability to cc: any "bylines" in the commit message Joe Perches
2016-08-31 19:34 ` Junio C Hamano
2016-08-31 19:39   ` Joe Perches [this message]
2016-08-31 20:09     ` Junio C Hamano
2016-08-31 22:10 ` Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472672344.4176.32.camel@perches.com \
    --to=joe@perches.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).