git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vasco Almeida <vascomalmeida@sapo.pt>
To: patthoyts@users.sourceforge.net
Cc: git@vger.kernel.org, "Shawn O . Pearce" <spearce@spearce.org>
Subject: Re: [PATCH 1/5] git-gui i18n: mark strings for translation
Date: Mon, 03 Oct 2016 12:57:52 +0000	[thread overview]
Message-ID: <1475499472.1776.26.camel@sapo.pt> (raw)
In-Reply-To: <8760p9wwr3.fsf@red.patthoyts.tk>

A Seg, 03-10-2016 às 11:30 +0100, Pat Thoyts escreveu:
> Vasco Almeida <vascomalmeida@sapo.pt> writes:
> 
> > 
> > Mark strings for translation in lib/index.tcl that were seemingly
> > left behind by 700e560 ("git-gui: Mark forgotten strings for
> > translation.", 2008-09-04) which marks string in
> > do_revert_selection
> > procedure.
> > These strings are passed to unstage_help and add_helper procedures.
> > 
> > Signed-off-by: Vasco Almeida <vascomalmeida@sapo.pt>
> > ---
> > lib/index.tcl | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/lib/index.tcl b/lib/index.tcl
> > index 74a81a7..3a3e534 100644
> > --- a/lib/index.tcl
> > +++ b/lib/index.tcl
> > @@ -291,7 +291,7 @@ proc do_unstage_selection {} {
> > 
> > 	if {[array size selected_paths] > 0} {
> > 		unstage_helper \
> > -			{Unstaging selected files from commit} \
> > +			[mc "Unstaging selected files from
> > commit"] \
> > 			[array names selected_paths]
> > 	} elseif {$current_diff_path ne {}} {
> > 		unstage_helper \
> > @@ -343,7 +343,7 @@ proc do_add_selection {} {
> > 
> > 	if {[array size selected_paths] > 0} {
> > 		add_helper \
> > -			{Adding selected files} \
> > +			[mc "Adding selected files"] \
> > 			[array names selected_paths]
> > 	} elseif {$current_diff_path ne {}} {
> > 		add_helper \
> > @@ -385,7 +385,7 @@ proc do_add_all {} {
> > 			set paths [concat $paths $untracked_paths]
> > 		}
> > 	}
> > -	add_helper {Adding all changed files} $paths
> > +	add_helper [mc "Adding all changed files"] $paths
> > }
> > 
> > proc revert_helper {txt paths} {
> 
> This series looks good. Especially noticing the misuse of the append
> command. Applied to my pu for now.
> Thank you,

I think Junio Hamano added PATCH 1/5 of this series to Git 'next'
branch and added the Portuguese translation of git-gui too.

      reply	other threads:[~2016-10-03 12:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-08 10:52 [PATCH 1/5] git-gui i18n: mark strings for translation Vasco Almeida
2016-05-08 10:52 ` [PATCH 2/5] git-gui i18n: internationalize use of colon punctuation Vasco Almeida
2016-05-08 10:52 ` [PATCH 3/5] git-gui i18n: mark "usage:" strings for translation Vasco Almeida
2016-05-08 10:52 ` [PATCH 4/5] git-gui: fix incorrect use of Tcl append command Vasco Almeida
2016-10-03 10:23   ` Pat Thoyts
2016-05-08 10:52 ` [PATCH 5/5] git-gui i18n: mark string in lib/error.tcl for translation Vasco Almeida
2016-10-03 10:30 ` [PATCH 1/5] git-gui i18n: mark strings " Pat Thoyts
2016-10-03 12:57   ` Vasco Almeida [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475499472.1776.26.camel@sapo.pt \
    --to=vascomalmeida@sapo.pt \
    --cc=git@vger.kernel.org \
    --cc=patthoyts@users.sourceforge.net \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).