From: Dennis Kaarsemaker <dennis@kaarsemaker.net>
To: Jeff King <peff@peff.net>
Cc: "Mantas Mikulėnas" <grawity@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] contrib: add credential helper for libsecret
Date: Tue, 11 Oct 2016 17:01:11 +0200 [thread overview]
Message-ID: <1476198071.3876.7.camel@kaarsemaker.net> (raw)
In-Reply-To: <20161010204654.krj44nk6xbjh4t2v@sigill.intra.peff.net>
On Mon, 2016-10-10 at 16:46 -0400, Jeff King wrote:
> On Mon, Oct 10, 2016 at 10:20:50PM +0200, Dennis Kaarsemaker wrote:
>
> > On Sun, 2016-10-09 at 15:34 +0300, Mantas Mikulėnas wrote:
> > > This is based on the existing gnome-keyring helper, but instead of
> > > libgnome-keyring (which was specific to GNOME and is deprecated), it
> > > uses libsecret which can support other implementations of XDG Secret
> > > Service API.
> > >
> > > Passes t0303-credential-external.sh.
> >
> > When setting credential.helper to this helper, I get the following output:
> >
> > $ git clone https://private-repo-url-removed private
> > Cloning into 'private'...
> > /home/dennis/code/git/contrib/credential/libsecret/ get: 1: /home/dennis/code/git/contrib/credential/libsecret/ get: /home/dennis/code/git/contrib/credential/libsecret/: Permission denied
> >
> > Looks suboptimal. Am I holding it wrong?
>
> That looks like a directory name in your error message. How did you set
> up credential.helper?
Doh.
I had done git config --global credential.helper ~/code/git/contrib/credential/libsecret/
After doing it properly (actual path to the binary), it works just
fine. The error message above is slightly suboptimal, but there's no
solution for pebkac.
D.
next prev parent reply other threads:[~2016-10-11 15:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 12:34 [PATCH] contrib: add credential helper for libsecret Mantas Mikulėnas
2016-10-10 18:34 ` Jeff King
2016-10-10 20:20 ` Dennis Kaarsemaker
2016-10-10 20:46 ` Jeff King
2016-10-11 15:01 ` Dennis Kaarsemaker [this message]
2016-10-11 15:01 ` Dennis Kaarsemaker
2016-10-11 19:36 ` Junio C Hamano
2016-10-11 19:48 ` Mantas Mikulėnas
2016-10-11 19:59 ` Mantas Mikulėnas
2016-10-11 20:09 ` Dennis Kaarsemaker
2016-10-11 20:13 ` Junio C Hamano
2016-10-11 20:19 ` Junio C Hamano
2016-10-11 20:32 ` Dennis Kaarsemaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476198071.3876.7.camel@kaarsemaker.net \
--to=dennis@kaarsemaker.net \
--cc=git@vger.kernel.org \
--cc=grawity@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).