From: David Turner <novalis@novalis.org>
To: git@vger.kernel.org
Cc: peff@peff.net
Subject: "disabling bitmap writing, as some objects are not being packed"?
Date: Fri, 16 Dec 2016 16:05:31 -0500 [thread overview]
Message-ID: <1481922331.28176.11.camel@frank> (raw)
I'm a bit confused by the message "disabling bitmap writing, as some
objects are not being packed". I see it the my gc.log file on my git
server.
1. Its presence in the gc.log file prevents future automatic garbage
collection. This seems bad. I understand the desire to avoid making
things worse if a past gc has run into issues. But this warning is
non-fatal; the only consequence is that many operations get slower. But
a lack of gc when there are too many packs causes that consequence too
(often a much worse slowdown than would be caused by the missing
bitmap).
So I wonder if it would be better for auto gc to grep gc.log for fatal
errors (as opposed to warnings) and only skip running if any are found.
Alternately, we could simply put warnings into gc.log.warning and
reserve gc.log for fatal errors. I'm not sure which would be simpler.
2. I don't understand what would cause that message. That is, what bad
thing am I doing that I should stop doing? I've briefly skimmed the
code and commit message, but the answer isn't leaping out at me.
next reply other threads:[~2016-12-16 21:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 21:05 David Turner [this message]
2016-12-16 21:27 ` "disabling bitmap writing, as some objects are not being packed"? Jeff King
2016-12-16 21:28 ` Junio C Hamano
2016-12-16 21:32 ` Jeff King
2016-12-16 21:40 ` David Turner
2016-12-16 21:49 ` Jeff King
2016-12-16 23:59 ` [PATCH] pack-objects: don't warn about bitmaps on incremental pack David Turner
2016-12-17 4:04 ` Jeff King
2016-12-19 16:03 ` David Turner
2016-12-17 7:50 ` "disabling bitmap writing, as some objects are not being packed"? Duy Nguyen
2017-02-08 1:03 ` David Turner
2017-02-08 6:45 ` Duy Nguyen
2017-02-08 8:24 ` David Turner
2017-02-08 8:37 ` Duy Nguyen
2017-02-08 17:44 ` Junio C Hamano
2017-02-08 19:05 ` David Turner
2017-02-08 19:08 ` Jeff King
2017-02-08 22:14 ` David Turner
2017-02-08 23:00 ` Jeff King
2017-02-09 0:18 ` Junio C Hamano
2017-02-09 1:12 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481922331.28176.11.camel@frank \
--to=novalis@novalis.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).