* ttk error when starting git gui
@ 2017-03-30 17:01 David Shrader
2017-03-30 19:54 ` Peter van der Does
2017-03-31 6:44 ` Jessie Hernandez
0 siblings, 2 replies; 12+ messages in thread
From: David Shrader @ 2017-03-30 17:01 UTC (permalink / raw)
To: git
Hello,
I get the following error when trying to start git gui:
Error in startup script: wrong # args: should be "ttk::style theme use
theme"
while executing
"ttk::style theme use"
(procedure "ttext" line 4)
invoked from within
"ttext $ui_workdir -background white -foreground black \
-borderwidth 0 \
-width 20 -height 10 \
-wrap none \
-takefocus 1 -highlightthickness 1\
..."
(file
"/home/dshrader/opt/toss2/common/git/2.12.2/libexec/git-core/git-gui"
line 3190)
I get this error with the latest released version 2.12.2. Two older git
versions are also available on this system, and neither has this issue.
Those older versions are 1.7.1 and 2.3.3. I don't see a call to ttext in
those corresponding git-gui executables, so that is probably why they work.
Here are the steps to reproduce:
1) cd to existing git repository
2) run 'git gui' (no gui comes up, and the error is printed in the terminal)
I'm running on a RHEL6 based system. Do I have an insufficient version
of whatever git gui uses for graphics in the later versions of git? When
I try 2.12.2 on my personal workstation running Fedora 25, I don't see
the same issue.
Thank you very much for your time,
David
--
David Shrader
HPC-ENV High Performance Computer Systems
Los Alamos National Lab
Email: dshrader <at> lanl.gov
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: ttk error when starting git gui
2017-03-30 17:01 ttk error when starting git gui David Shrader
@ 2017-03-30 19:54 ` Peter van der Does
2017-03-30 20:44 ` Dennis Kaarsemaker
2017-03-30 21:33 ` David Shrader
2017-03-31 6:44 ` Jessie Hernandez
1 sibling, 2 replies; 12+ messages in thread
From: Peter van der Does @ 2017-03-30 19:54 UTC (permalink / raw)
To: git
On 3/30/17 1:01 PM, David Shrader wrote:
> Hello,
>
> I get the following error when trying to start git gui:
>
> Error in startup script: wrong # args: should be "ttk::style theme use
> theme"
> while executing
> "ttk::style theme use"
> (procedure "ttext" line 4)
> invoked from within
> "ttext $ui_workdir -background white -foreground black \
> -borderwidth 0 \
> -width 20 -height 10 \
> -wrap none \
> -takefocus 1 -highlightthickness 1\
> ..."
> (file
> "/home/dshrader/opt/toss2/common/git/2.12.2/libexec/git-core/git-gui"
> line 3190)
>
> I get this error with the latest released version 2.12.2. Two older git
> versions are also available on this system, and neither has this issue.
> Those older versions are 1.7.1 and 2.3.3. I don't see a call to ttext in
> those corresponding git-gui executables, so that is probably why they work.
>
> Here are the steps to reproduce:
>
> 1) cd to existing git repository
> 2) run 'git gui' (no gui comes up, and the error is printed in the
> terminal)
>
> I'm running on a RHEL6 based system. Do I have an insufficient version
> of whatever git gui uses for graphics in the later versions of git? When
> I try 2.12.2 on my personal workstation running Fedora 25, I don't see
> the same issue.
>
> Thank you very much for your time,
> David
>
It looks like the git gui needs TCL/TK 8.6.0 or higher. Since that
version the command 'ttk::style theme use' has been changed, which
allows the command to be run without an argument and then returning the
current theme used.
I believe RHEL6 use Tk-8.5.7 but I can't be 100% sure.
--
Peter van der Does
Facebook : https://www.facebook.com/petervanderdoes
Twitter : https://twitter.com/petervanderdoes
GitHub : https://github.com/petervanderdoes
About Me : https://about.me/petervanderdoes
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: ttk error when starting git gui
2017-03-30 19:54 ` Peter van der Does
@ 2017-03-30 20:44 ` Dennis Kaarsemaker
2017-03-30 21:33 ` David Shrader
1 sibling, 0 replies; 12+ messages in thread
From: Dennis Kaarsemaker @ 2017-03-30 20:44 UTC (permalink / raw)
To: Peter van der Does, git
On Thu, 2017-03-30 at 15:54 -0400, Peter van der Does wrote:
> It looks like the git gui needs TCL/TK 8.6.0 or higher. Since that
> version the command 'ttk::style theme use' has been changed, which
> allows the command to be run without an argument and then returning the
> current theme used.
> I believe RHEL6 use Tk-8.5.7 but I can't be 100% sure.
It does.
$ rpm -q tk
tk-8.5.7-5.el6.x86_64
D.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: ttk error when starting git gui
2017-03-30 19:54 ` Peter van der Does
2017-03-30 20:44 ` Dennis Kaarsemaker
@ 2017-03-30 21:33 ` David Shrader
1 sibling, 0 replies; 12+ messages in thread
From: David Shrader @ 2017-03-30 21:33 UTC (permalink / raw)
To: Peter van der Does, git
On 03/30/2017 01:54 PM, Peter van der Does wrote:
> On 3/30/17 1:01 PM, David Shrader wrote:
>> Hello,
>>
>> I get the following error when trying to start git gui:
>>
>> Error in startup script: wrong # args: should be "ttk::style theme use
>> theme"
>> while executing
>> "ttk::style theme use"
>> (procedure "ttext" line 4)
>> invoked from within
>> "ttext $ui_workdir -background white -foreground black \
>> -borderwidth 0 \
>> -width 20 -height 10 \
>> -wrap none \
>> -takefocus 1 -highlightthickness 1\
>> ..."
>> (file
>> "/home/dshrader/opt/toss2/common/git/2.12.2/libexec/git-core/git-gui"
>> line 3190)
>>
>> I get this error with the latest released version 2.12.2. Two older git
>> versions are also available on this system, and neither has this issue.
>> Those older versions are 1.7.1 and 2.3.3. I don't see a call to ttext in
>> those corresponding git-gui executables, so that is probably why they work.
>>
>> Here are the steps to reproduce:
>>
>> 1) cd to existing git repository
>> 2) run 'git gui' (no gui comes up, and the error is printed in the
>> terminal)
>>
>> I'm running on a RHEL6 based system. Do I have an insufficient version
>> of whatever git gui uses for graphics in the later versions of git? When
>> I try 2.12.2 on my personal workstation running Fedora 25, I don't see
>> the same issue.
>>
>> Thank you very much for your time,
>> David
>>
>
> It looks like the git gui needs TCL/TK 8.6.0 or higher. Since that
> version the command 'ttk::style theme use' has been changed, which
> allows the command to be run without an argument and then returning the
> current theme used.
> I believe RHEL6 use Tk-8.5.7 but I can't be 100% sure.
>
Yep, 8.5.7 is what I have on the RHEL6-based system. Thanks for the info!
David
--
David Shrader
HPC-ENV High Performance Computer Systems
Los Alamos National Lab
Email: dshrader <at> lanl.gov
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: ttk error when starting git gui
2017-03-30 17:01 ttk error when starting git gui David Shrader
2017-03-30 19:54 ` Peter van der Does
@ 2017-03-31 6:44 ` Jessie Hernandez
2017-03-31 7:33 ` Konstantin Khomoutov
1 sibling, 1 reply; 12+ messages in thread
From: Jessie Hernandez @ 2017-03-31 6:44 UTC (permalink / raw)
To: David Shrader; +Cc: git
> Hello,
>
> I get the following error when trying to start git gui:
>
> Error in startup script: wrong # args: should be "ttk::style theme use
> theme"
> while executing
> "ttk::style theme use"
> (procedure "ttext" line 4)
> invoked from within
> "ttext $ui_workdir -background white -foreground black \
> -borderwidth 0 \
> -width 20 -height 10 \
> -wrap none \
> -takefocus 1 -highlightthickness 1\
> ..."
> (file
> "/home/dshrader/opt/toss2/common/git/2.12.2/libexec/git-core/git-gui"
> line 3190)
>
> I get this error with the latest released version 2.12.2. Two older git
> versions are also available on this system, and neither has this issue.
> Those older versions are 1.7.1 and 2.3.3. I don't see a call to ttext in
> those corresponding git-gui executables, so that is probably why they
> work.
>
> Here are the steps to reproduce:
>
> 1) cd to existing git repository
> 2) run 'git gui' (no gui comes up, and the error is printed in the
> terminal)
>
> I'm running on a RHEL6 based system. Do I have an insufficient version
> of whatever git gui uses for graphics in the later versions of git? When
> I try 2.12.2 on my personal workstation running Fedora 25, I don't see
> the same issue.
>
> Thank you very much for your time,
> David
Hi David,
I also got this problem when I wanted to build and run git 2.10.x.
I have added the following change to git-gui/git-gui.sh
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index 5bc21b878..5ce59ef94 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -894,7 +894,7 @@ set default_config(gui.fontui) [font configure font_ui]
set default_config(gui.fontdiff) [font configure font_diff]
# TODO: this option should be added to the git-config documentation
set default_config(gui.maxfilesdisplayed) 5000
-set default_config(gui.usettk) 1
+set default_config(gui.usettk) 0
set default_config(gui.warndetachedcommit) 1
set default_config(gui.tabsize) 8
set font_descs {
If you guys want I can submit it as a patch.
But i assume that 'fixing' this by disabling the feature is not really
what we want.
-----------------
Jessie Hernandez
> --
> David Shrader
> HPC-ENV High Performance Computer Systems
> Los Alamos National Lab
> Email: dshrader <at> lanl.gov
>
>
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: ttk error when starting git gui
2017-03-31 6:44 ` Jessie Hernandez
@ 2017-03-31 7:33 ` Konstantin Khomoutov
2017-03-31 7:45 ` Jessie Hernandez
0 siblings, 1 reply; 12+ messages in thread
From: Konstantin Khomoutov @ 2017-03-31 7:33 UTC (permalink / raw)
To: git; +Cc: David Shrader, git
On Fri, 31 Mar 2017 08:44:27 +0200
"Jessie Hernandez" <git@jessiehernandez.com> wrote:
[...]
> I also got this problem when I wanted to build and run git 2.10.x.
> I have added the following change to git-gui/git-gui.sh
>
> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
> index 5bc21b878..5ce59ef94 100755
> --- a/git-gui/git-gui.sh
> +++ b/git-gui/git-gui.sh
> @@ -894,7 +894,7 @@ set default_config(gui.fontui) [font configure
> font_ui] set default_config(gui.fontdiff) [font configure font_diff]
> # TODO: this option should be added to the git-config documentation
> set default_config(gui.maxfilesdisplayed) 5000
> -set default_config(gui.usettk) 1
> +set default_config(gui.usettk) 0
> set default_config(gui.warndetachedcommit) 1
> set default_config(gui.tabsize) 8
> set font_descs {
>
>
> If you guys want I can submit it as a patch.
> But i assume that 'fixing' this by disabling the feature is not really
> what we want.
It's possible to have ttk with 8.5 as well (say, here on Debian 8.5
ships with ttk enabled).
A proper patch would be
-set default_config(gui.usettk) 1
+set default_config(gui.usettk) [namespace exists ::ttk]
Could you please test it on your system?
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: ttk error when starting git gui
2017-03-31 7:33 ` Konstantin Khomoutov
@ 2017-03-31 7:45 ` Jessie Hernandez
2017-03-31 7:53 ` Jessie Hernandez
2017-03-31 7:56 ` Konstantin Khomoutov
0 siblings, 2 replies; 12+ messages in thread
From: Jessie Hernandez @ 2017-03-31 7:45 UTC (permalink / raw)
To: Konstantin Khomoutov; +Cc: git, David Shrader, git
> On Fri, 31 Mar 2017 08:44:27 +0200
> "Jessie Hernandez" <git@jessiehernandez.com> wrote:
>
> [...]
>> I also got this problem when I wanted to build and run git 2.10.x.
>> I have added the following change to git-gui/git-gui.sh
>>
>> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
>> index 5bc21b878..5ce59ef94 100755
>> --- a/git-gui/git-gui.sh
>> +++ b/git-gui/git-gui.sh
>> @@ -894,7 +894,7 @@ set default_config(gui.fontui) [font configure
>> font_ui] set default_config(gui.fontdiff) [font configure font_diff]
>> # TODO: this option should be added to the git-config documentation
>> set default_config(gui.maxfilesdisplayed) 5000
>> -set default_config(gui.usettk) 1
>> +set default_config(gui.usettk) 0
>> set default_config(gui.warndetachedcommit) 1
>> set default_config(gui.tabsize) 8
>> set font_descs {
>>
>>
>> If you guys want I can submit it as a patch.
>> But i assume that 'fixing' this by disabling the feature is not really
>> what we want.
>
> It's possible to have ttk with 8.5 as well (say, here on Debian 8.5
> ships with ttk enabled).
>
> A proper patch would be
>
> -set default_config(gui.usettk) 1
> +set default_config(gui.usettk) [namespace exists ::ttk]
>
> Could you please test it on your system?
>
Yeah that seems to work.
Thanks for this.
I have tried it with git 2.12.2
Jessie Hernandez
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: ttk error when starting git gui
2017-03-31 7:45 ` Jessie Hernandez
@ 2017-03-31 7:53 ` Jessie Hernandez
2017-03-31 7:58 ` Konstantin Khomoutov
2017-03-31 7:56 ` Konstantin Khomoutov
1 sibling, 1 reply; 12+ messages in thread
From: Jessie Hernandez @ 2017-03-31 7:53 UTC (permalink / raw)
To: git; +Cc: Konstantin Khomoutov, David Shrader, git
>> On Fri, 31 Mar 2017 08:44:27 +0200
>> "Jessie Hernandez" <git@jessiehernandez.com> wrote:
>>
>> [...]
>>> I also got this problem when I wanted to build and run git 2.10.x.
>>> I have added the following change to git-gui/git-gui.sh
>>>
>>> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
>>> index 5bc21b878..5ce59ef94 100755
>>> --- a/git-gui/git-gui.sh
>>> +++ b/git-gui/git-gui.sh
>>> @@ -894,7 +894,7 @@ set default_config(gui.fontui) [font configure
>>> font_ui] set default_config(gui.fontdiff) [font configure font_diff]
>>> # TODO: this option should be added to the git-config documentation
>>> set default_config(gui.maxfilesdisplayed) 5000
>>> -set default_config(gui.usettk) 1
>>> +set default_config(gui.usettk) 0
>>> set default_config(gui.warndetachedcommit) 1
>>> set default_config(gui.tabsize) 8
>>> set font_descs {
>>>
>>>
>>> If you guys want I can submit it as a patch.
>>> But i assume that 'fixing' this by disabling the feature is not really
>>> what we want.
>>
>> It's possible to have ttk with 8.5 as well (say, here on Debian 8.5
>> ships with ttk enabled).
>>
>> A proper patch would be
>>
>> -set default_config(gui.usettk) 1
>> +set default_config(gui.usettk) [namespace exists ::ttk]
>>
>> Could you please test it on your system?
>>
>
> Yeah that seems to work.
> Thanks for this.
>
> I have tried it with git 2.12.2
>
> Jessie Hernandez
>
Hi Konstantin,
I spoke to soon. :(
It does not work. I forgot to do a install when testing.
Sorry for the confusion.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: ttk error when starting git gui
2017-03-31 7:53 ` Jessie Hernandez
@ 2017-03-31 7:58 ` Konstantin Khomoutov
2017-03-31 11:29 ` Jessie Hernandez
0 siblings, 1 reply; 12+ messages in thread
From: Konstantin Khomoutov @ 2017-03-31 7:58 UTC (permalink / raw)
To: git; +Cc: David Shrader, git
On Fri, 31 Mar 2017 09:53:38 +0200
"Jessie Hernandez" <git@jessiehernandez.com> wrote:
[...]
> >> It's possible to have ttk with 8.5 as well (say, here on Debian 8.5
> >> ships with ttk enabled).
> >>
> >> A proper patch would be
> >>
> >> -set default_config(gui.usettk) 1
> >> +set default_config(gui.usettk) [namespace exists ::ttk]
> >>
> >> Could you please test it on your system?
> >>
> >
> > Yeah that seems to work.
> > Thanks for this.
> >
> > I have tried it with git 2.12.2
[...]
> I spoke to soon. :(
> It does not work. I forgot to do a install when testing.
> Sorry for the confusion.
Care to elaborate on the exact error, please?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: ttk error when starting git gui
2017-03-31 7:58 ` Konstantin Khomoutov
@ 2017-03-31 11:29 ` Jessie Hernandez
2017-03-31 14:34 ` Konstantin Khomoutov
0 siblings, 1 reply; 12+ messages in thread
From: Jessie Hernandez @ 2017-03-31 11:29 UTC (permalink / raw)
To: Konstantin Khomoutov; +Cc: git, David Shrader, git
> On Fri, 31 Mar 2017 09:53:38 +0200
> "Jessie Hernandez" <git@jessiehernandez.com> wrote:
>
> [...]
>> >> It's possible to have ttk with 8.5 as well (say, here on Debian 8.5
>> >> ships with ttk enabled).
>> >>
>> >> A proper patch would be
>> >>
>> >> -set default_config(gui.usettk) 1
>> >> +set default_config(gui.usettk) [namespace exists ::ttk]
>> >>
>> >> Could you please test it on your system?
>> >>
>> >
>> > Yeah that seems to work.
>> > Thanks for this.
>> >
>> > I have tried it with git 2.12.2
> [...]
>> I spoke to soon. :(
>> It does not work. I forgot to do a install when testing.
>> Sorry for the confusion.
>
> Care to elaborate on the exact error, please?
>
The error I get is the following
Error in startup script: wrong # args: should be "ttk::style theme use theme"
while executing
"ttk::style theme use"
(procedure "ttext" line 4)
invoked from within
"ttext $ui_workdir -background white -foreground black \
-borderwidth 0 \
-width 20 -height 10 \
-wrap none \
-takefocus 1 -highlightthickness 1\
..."
(file "/usr/libexec/git-core/git-gui" line 3190)
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: ttk error when starting git gui
2017-03-31 11:29 ` Jessie Hernandez
@ 2017-03-31 14:34 ` Konstantin Khomoutov
0 siblings, 0 replies; 12+ messages in thread
From: Konstantin Khomoutov @ 2017-03-31 14:34 UTC (permalink / raw)
To: git; +Cc: David Shrader, git, Pat Thoyts
On Fri, 31 Mar 2017 13:29:04 +0200
"Jessie Hernandez" <git@jessiehernandez.com> wrote:
> > On Fri, 31 Mar 2017 09:53:38 +0200
> > "Jessie Hernandez" <git@jessiehernandez.com> wrote:
> >
> > [...]
> >> >> It's possible to have ttk with 8.5 as well (say, here on Debian
> >> >> 8.5 ships with ttk enabled).
> >> >>
> >> >> A proper patch would be
> >> >>
> >> >> -set default_config(gui.usettk) 1
> >> >> +set default_config(gui.usettk) [namespace exists ::ttk]
> >> >>
> >> >> Could you please test it on your system?
> >> >>
> >> >
> >> > Yeah that seems to work.
> >> > Thanks for this.
> >> >
> >> > I have tried it with git 2.12.2
> > [...]
> >> I spoke to soon. :(
> >> It does not work. I forgot to do a install when testing.
> >> Sorry for the confusion.
> >
> > Care to elaborate on the exact error, please?
> >
>
> The error I get is the following
>
> Error in startup script: wrong # args: should be "ttk::style theme
> use theme" while executing
> "ttk::style theme use"
> (procedure "ttext" line 4)
> invoked from within
> "ttext $ui_workdir -background white -foreground black \
> -borderwidth 0 \
> -width 20 -height 10 \
> -wrap none \
> -takefocus 1 -highlightthickness 1\
> ..."
> (file "/usr/libexec/git-core/git-gui" line 3190)
Too bad: the git-gui relies on the [ttk::style theme use] command --
that is, the two-argument invocation of [ttk::style] -- to return
the theme being currently in use, and this feature was implemented
on 2008-05-27 [1] by Pat Thoyts.
Judging from the output of
fossil descendants e83b7dd29ddae998f96538584afb518849ac1e2c
the first Tk release to have this change was 8.6b2.
So the proper fix appears to be more involved:
set default_config(gui.usettk) \
[expr {[package vcompare [info patchlevel] 8.6b2] >= 0}]
(The slash+newline sequence is not needed -- it's here mostly
for pretty-printing.)
1. http://core.tcl.tk/tk/info/e83b7dd29ddae998
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: ttk error when starting git gui
2017-03-31 7:45 ` Jessie Hernandez
2017-03-31 7:53 ` Jessie Hernandez
@ 2017-03-31 7:56 ` Konstantin Khomoutov
1 sibling, 0 replies; 12+ messages in thread
From: Konstantin Khomoutov @ 2017-03-31 7:56 UTC (permalink / raw)
To: git; +Cc: David Shrader, git
On Fri, 31 Mar 2017 09:45:03 +0200
"Jessie Hernandez" <git@jessiehernandez.com> wrote:
> >> I also got this problem when I wanted to build and run git 2.10.x.
> >> I have added the following change to git-gui/git-gui.sh
> >>
> >> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
> >> index 5bc21b878..5ce59ef94 100755
> >> --- a/git-gui/git-gui.sh
> >> +++ b/git-gui/git-gui.sh
> >> @@ -894,7 +894,7 @@ set default_config(gui.fontui) [font configure
> >> font_ui] set default_config(gui.fontdiff) [font configure
> >> font_diff]
> >> # TODO: this option should be added to the git-config
> >> # documentation
> >> set default_config(gui.maxfilesdisplayed) 5000
> >> -set default_config(gui.usettk) 1
> >> +set default_config(gui.usettk) 0
> >> set default_config(gui.warndetachedcommit) 1
> >> set default_config(gui.tabsize) 8
> >> set font_descs {
> >>
> >> If you guys want I can submit it as a patch.
> >> But i assume that 'fixing' this by disabling the feature is not
> >> really what we want.
> >
> > It's possible to have ttk with 8.5 as well (say, here on Debian 8.5
> > ships with ttk enabled).
> >
> > A proper patch would be
> >
> > -set default_config(gui.usettk) 1
> > +set default_config(gui.usettk) [namespace exists ::ttk]
> >
> > Could you please test it on your system?
> >
>
> Yeah that seems to work.
> Thanks for this.
>
> I have tried it with git 2.12.2
Please consider re-posting this as a proper patch, then. ;-)
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-03-31 14:34 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-30 17:01 ttk error when starting git gui David Shrader
2017-03-30 19:54 ` Peter van der Does
2017-03-30 20:44 ` Dennis Kaarsemaker
2017-03-30 21:33 ` David Shrader
2017-03-31 6:44 ` Jessie Hernandez
2017-03-31 7:33 ` Konstantin Khomoutov
2017-03-31 7:45 ` Jessie Hernandez
2017-03-31 7:53 ` Jessie Hernandez
2017-03-31 7:58 ` Konstantin Khomoutov
2017-03-31 11:29 ` Jessie Hernandez
2017-03-31 14:34 ` Konstantin Khomoutov
2017-03-31 7:56 ` Konstantin Khomoutov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).