From: Daniel Ferreira <bnmvco@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, Johannes.Schindelin@gmx.de, avarab@gmail.com,
jrnieder@gmail.com, Daniel Ferreira <bnmvco@gmail.com>
Subject: [PATCH v2 4/4] add--interactive: use add-interactive--helper for status_cmd
Date: Tue, 16 May 2017 01:00:34 -0300 [thread overview]
Message-ID: <1494907234-28903-5-git-send-email-bnmvco@gmail.com> (raw)
In-Reply-To: <1494907234-28903-1-git-send-email-bnmvco@gmail.com>
Call the newly introduced git-add-interactive--helper builtin on
status_cmd() instead of relying on git-add--interactive's Perl
functions to build print the numstat.
Signed-off-by: Daniel Ferreira <bnmvco@gmail.com>
---
git-add--interactive.perl | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/git-add--interactive.perl b/git-add--interactive.perl
index 709a5f6..8c192bf 100755
--- a/git-add--interactive.perl
+++ b/git-add--interactive.perl
@@ -632,9 +632,7 @@ EOF
}
sub status_cmd {
- list_and_choose({ LIST_ONLY => 1, HEADER => $status_head },
- list_modified());
- print "\n";
+ system(qw(git add--helper --status));
}
sub say_n_paths {
--
2.7.4 (Apple Git-66)
next prev parent reply other threads:[~2017-05-16 4:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 4:00 [PATCH v2 0/4] Port git-add--interactive.perl:status_cmd to C Daniel Ferreira
2017-05-16 4:00 ` [PATCH v2 1/4] diff: export diffstat interface Daniel Ferreira
2017-05-16 4:00 ` [PATCH v2 2/4] add--helper: create builtin helper for interactive add Daniel Ferreira
2017-05-16 4:00 ` [PATCH v2 3/4] add--helper: implement interactive status command Daniel Ferreira
2017-05-16 4:39 ` Junio C Hamano
2017-05-16 4:00 ` Daniel Ferreira [this message]
2018-11-26 17:18 ` [PATCH v2 0/4] Port git-add--interactive.perl:status_cmd to C Slavica Djukic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494907234-28903-5-git-send-email-bnmvco@gmail.com \
--to=bnmvco@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).