From: Dennis Kaarsemaker <dennis@kaarsemaker.net>
To: Elliott Cable <me@ell.io>, Git Mailing List <git@vger.kernel.org>
Subject: Re: persistent-https, url insteadof, and `git submodule`
Date: Fri, 19 May 2017 23:43:06 +0200 [thread overview]
Message-ID: <1495230186.19473.7.camel@kaarsemaker.net> (raw)
In-Reply-To: <CAPZ477MCsBsfbqKzp69MT_brwz-0aes6twJofQrhizUBV7ZoeA@mail.gmail.com>
On Fri, 2017-05-19 at 14:57 -0500, Elliott Cable wrote:
> Set up `persistent-https` as described in the [README][]; including the
> ‘rewrite https urls’ feature in `.gitconfig`:
>
> [url "persistent-https"]
> insteadof = https
> [url "persistent-http"]
> insteadof = http
>
> Unfortunately, this breaks `git submodule add`:
>
> > git submodule add https://github.com/nodenv/nodenv.git \
> ./Vendor/nodenv
> Cloning into '/Users/ec/Library/System Repo/Vendor/nodenv'...
> fatal: transport 'persistent-https' not allowed
> fatal: clone of 'https://github.com/nodenv/nodenv.git' into
> submodule path '/Users/ec/Library/System Repo/Vendor/nodenv' failed
>
> Presumably this isn't intended behaviour?
It actually is. git-submodule sets GIT_PROTOCOL_FROM_USER to 0, which
makes git not trust any urls except http(s), git, ssh and file urls
unless you explicitely configure git to allow it. See the
GIT_ALLOW_PROTOCOL section in man git and the git-config section it
links to.
D.
next prev parent reply other threads:[~2017-05-19 21:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 19:57 persistent-https, url insteadof, and `git submodule` Elliott Cable
2017-05-19 21:43 ` Dennis Kaarsemaker [this message]
2017-05-19 21:55 ` Dennis Kaarsemaker
2017-05-20 7:07 ` Jeff King
2017-05-26 16:22 ` Elliott Cable
2017-05-31 4:50 ` Jeff King
2017-05-31 14:23 ` Ævar Arnfjörð Bjarmason
2017-05-31 21:22 ` Jeff King
2017-05-31 5:18 ` [PATCH] docs/config: mention protocol implications of url.insteadOf Jeff King
2017-06-01 0:15 ` Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495230186.19473.7.camel@kaarsemaker.net \
--to=dennis@kaarsemaker.net \
--cc=git@vger.kernel.org \
--cc=me@ell.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).