git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] status tests: fix a minor indenting issue
@ 2017-06-21 12:31 Kaartic Sivaraam
  2017-06-21 16:34 ` Junio C Hamano
  0 siblings, 1 reply; 3+ messages in thread
From: Kaartic Sivaraam @ 2017-06-21 12:31 UTC (permalink / raw)
  To: gitster; +Cc: git, avarab

Change the indentation from "\t " to "\t". This indenting issue was
introduced when the test was added in commit
1d2f393ac9 ("status/commit: show staged submodules regardless of
ignore config", 2014-04-05).

Helped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 t/t7508-status.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t7508-status.sh b/t/t7508-status.sh
index 5edcc6edf..35ea0b707 100755
--- a/t/t7508-status.sh
+++ b/t/t7508-status.sh
@@ -1494,7 +1494,7 @@ EOF
 test_expect_success 'git commit -m will commit a staged but ignored
submodule' '
 	git commit -uno -m message &&
 	git status -s --ignore-submodules=dirty >output &&
-	 test_i18ngrep ! "^M. sm" output &&
+	test_i18ngrep ! "^M. sm" output &&
 	git config --remove-section submodule.subname &&
 	git config -f .gitmodules  --remove-section submodule.subname
 '
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] status tests: fix a minor indenting issue
  2017-06-21 12:31 [PATCH] status tests: fix a minor indenting issue Kaartic Sivaraam
@ 2017-06-21 16:34 ` Junio C Hamano
  2017-06-21 18:18   ` Kaartic Sivaraam
  0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2017-06-21 16:34 UTC (permalink / raw)
  To: Kaartic Sivaraam; +Cc: git, avarab

Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:

> Change the indentation from "\t " to "\t". This indenting issue was
> introduced when the test was added in commit
> 1d2f393ac9 ("status/commit: show staged submodules regardless of
> ignore config", 2014-04-05).
>
> Helped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  t/t7508-status.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t7508-status.sh b/t/t7508-status.sh
> index 5edcc6edf..35ea0b707 100755
> --- a/t/t7508-status.sh
> +++ b/t/t7508-status.sh
> @@ -1494,7 +1494,7 @@ EOF
>  test_expect_success 'git commit -m will commit a staged but ignored
> submodule' '
>  	git commit -uno -m message &&
>  	git status -s --ignore-submodules=dirty >output &&
> -	 test_i18ngrep ! "^M. sm" output &&
> +	test_i18ngrep ! "^M. sm" output &&
>  	git config --remove-section submodule.subname &&
>  	git config -f .gitmodules  --remove-section submodule.subname
>  '
> -- 
> 2.11.0

Your patch is heavily whitespace damaged, line-wrapped and
full of <A0> (nbsp??) bytes as can be seen by downloading from

http://public-inbox.org/git/%3C1498048305.1746.6.camel@gmail.com%3E/raw

I'll hand-tweak to make it apply, so no need to resend but please
make sure you can send your patches cleanly before sending a more
substantial patch.

Thanks.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] status tests: fix a minor indenting issue
  2017-06-21 16:34 ` Junio C Hamano
@ 2017-06-21 18:18   ` Kaartic Sivaraam
  0 siblings, 0 replies; 3+ messages in thread
From: Kaartic Sivaraam @ 2017-06-21 18:18 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git, avarab

On Wed, 2017-06-21 at 09:34 -0700, Junio C Hamano wrote:
> Your patch is heavily whitespace damaged, line-wrapped and
> full of <A0> (nbsp??) bytes as can be seen by downloading from
> 
> http://public-inbox.org/git/%3C1498048305.1746.6.camel@gmail.com%3E/r
> aw
> 
> I'll hand-tweak to make it apply, so no need to resend but please
> make sure you can send your patches cleanly before sending a more
> substantial patch.
> 
> Thanks.
> 
Sorry about that. As specified in another thread, will be careful about
sending patches through email-clients in future.

-- 
Regards,
Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-21 18:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-21 12:31 [PATCH] status tests: fix a minor indenting issue Kaartic Sivaraam
2017-06-21 16:34 ` Junio C Hamano
2017-06-21 18:18   ` Kaartic Sivaraam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).