From: "Rubén Justo" <rjusto@gmail.com>
To: Isoken June Ibizugbe <isokenjune@gmail.com>, git@vger.kernel.org
Cc: Dragan Simic <dsimic@manjaro.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v3] builtin/branch.c: adjust error messages to coding guidelines
Date: Mon, 23 Oct 2023 22:17:33 +0200 [thread overview]
Message-ID: <14df596a-d0ef-46aa-97c6-3c9f0da1975f@gmail.com> (raw)
In-Reply-To: <20231023160656.4341-1-isokenjune@gmail.com>
On 23-oct-2023 17:06:56, Isoken June Ibizugbe wrote:
Just for reference, to avoid confusion, this is technically the fourth
version.
> As per the CodingGuidelines document, it is recommended that error messages
> such as die(), error() and warning(), should start with a lowercase letter
> and should not end with a period.
>
> This patch adjusts tests to match updated messages.
>
> Signed-off-by: Isoken June Ibizugbe <isokenjune@gmail.com>
> ---
It is often convenient to include here, after this three dash line, a
description of the changes introduced in the new iteration.
In this particular case, a range-diff is very helpful.
This is the range-diff with v2:
1: a4e8bb1b4c ! 1: c4ae0c1cce builtin/branch.c: adjust error messages to coding guidelines
@@ Metadata
## Commit message ##
builtin/branch.c: adjust error messages to coding guidelines
- As per the CodingGuidelines document, it is recommended that a single-line
- message provided to error messages such as die(), error() and warning(),
- should start with a lowercase letter and should not end with a period.
- Also this patch fixes the tests broken by the changes.
+ As per the CodingGuidelines document, it is recommended that error messages
+ such as die(), error() and warning(), should start with a lowercase letter
+ and should not end with a period.
+
+ This patch adjusts tests to match updated messages.
Signed-off-by: Isoken June Ibizugbe <isokenjune@gmail.com>
As we can see, the only difference is in the commit message.
The new wording is better; it avoids the distraction introduced in v2.
And, as Dragan suggested about /the other v3/, the wrapping is correct.
The rest of the patch is equal to the previous iteration (v2), which
already seemed correct to me.
Thank you.
next prev parent reply other threads:[~2023-10-23 20:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 14:57 [PATCH v3] builtin/branch.c: adjust error messages to coding guidelines Isoken June Ibizugbe
2023-10-23 15:05 ` Dragan Simic
2023-10-23 16:06 ` Isoken June Ibizugbe
2023-10-23 20:17 ` Rubén Justo [this message]
2023-10-23 20:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14df596a-d0ef-46aa-97c6-3c9f0da1975f@gmail.com \
--to=rjusto@gmail.com \
--cc=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=isokenjune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).