git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
To: phillip.wood@dunelm.org.uk, git@vger.kernel.org
Subject: Re: [PATCH] doc: update information about windows build
Date: Sun, 17 Sep 2017 19:12:57 +0530	[thread overview]
Message-ID: <1505655777.14232.3.camel@gmail.com> (raw)
In-Reply-To: <80afe093-aceb-9478-f0d2-d69f7f75eaab@talktalk.net>

On Sun, 2017-09-17 at 14:24 +0100, Phillip Wood wrote:
> 
>  From that commit:
> diff --git a/ci/run-windows-build.sh b/ci/run-windows-build.sh
> new file mode 100755
> index 000000000..4e3a50b60
> --- /dev/null
> +++ b/ci/run-windows-build.sh
> @@ -0,0 +1,74 @@
> +#!/usr/bin/env bash
> +#
> +# Script to trigger the a Git for Windows build and test run.
> +# Set the $GFW_CI_TOKEN as environment variable.
> +# Pass the branch (only branches on https://github.com/git/git are
> +# supported) and a commit hash.
> +#
> 
> so only git/git from github gets built on windows, not other peoples 
> trees. One cannot use travis to test ones changes on windows before 
> submitting them
> 

Thanks for pointing it out didn't notice it. I have been confused by
the presence of the build named 'Windows' that I see even on my tree. I
 always see a green check mark near it which tricked me into believing
that they were running successfully. I didn't know they were being
skipped all these days! 

May be the Windows build exit with failure on other repos rather than
saying it passes?

---
Kaartic

  reply	other threads:[~2017-09-17 13:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-17  5:28 [PATCH] doc: update information about windows build Kaartic Sivaraam
2017-09-17 13:24 ` Phillip Wood
2017-09-17 13:42   ` Kaartic Sivaraam [this message]
2017-09-17 19:02     ` Phillip Wood
2017-09-19  9:27       ` Kaartic Sivaraam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505655777.14232.3.camel@gmail.com \
    --to=kaarticsivaraam91196@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).