From: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH v2] doc: camelCase the config variables to improve readability
Date: Sun, 24 Sep 2017 10:51:03 +0530 [thread overview]
Message-ID: <1506230463.2425.2.camel@gmail.com> (raw)
In-Reply-To: <xmqqmv5lhre2.fsf@gitster.mtv.corp.google.com>
On Sun, 2017-09-24 at 09:28 +0900, Junio C Hamano wrote:
> Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:
>
> > A few configuration variable names of Git are composite words. References
> > to such variables in manpages are hard to read because they use all-lowercase
> > names, without indicating where each word ends and begins.
> >
> > Improve its readability by using camelCase instead. Git treats these
> > names case-insensitively so this does not affect functionality. This
> > also ensures consistency with other parts of the docs that use camelCase
> > fo refer to configuration variable names.
>
> s/fo/to/ (or s/fo/in order to/)?
>
Yeah, a typo that I missed.
> Perhaps
>
> References to multi-word configuration variable names in our
> documentation must consistently use camelCase to highlight
> where the word boundaries are, even though these are treated
> case insensitively.
>
> Fix a few places that spell them in all lowercase, which
> makes them harder to read.
>
> may be a more succinct way to say the same thing. We state the rule
> upfront, explain what the rule is for, and tell the codebase to
> apply the rule. That should cover everything your version and
> Jonathan's version wanted to convey, I'd think.
>
Much better, thanks. Will resend with this updated message.
---
Kaartic
next prev parent reply other threads:[~2017-09-24 11:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 12:46 [PATCH] doc: camelCase the config variables to improve readability Kaartic Sivaraam
2017-09-19 20:22 ` Jonathan Nieder
2017-09-20 8:03 ` Kaartic Sivaraam
2017-09-23 4:56 ` [PATCH v2] " Kaartic Sivaraam
2017-09-24 0:28 ` Junio C Hamano
2017-09-24 5:21 ` Kaartic Sivaraam [this message]
2017-09-25 8:27 ` [PATCH v3] " Kaartic Sivaraam
-- strict thread matches above, loose matches on Subject: below --
2017-09-20 5:27 [PATCH v2] for_each_string_list_item: avoid undefined behavior for empty list Jonathan Nieder
2017-09-20 12:22 ` [PATCH v2] doc: camelCase the config variables to improve readability Kaartic Sivaraam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506230463.2425.2.camel@gmail.com \
--to=kaarticsivaraam91196@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).