From: David Turner <novalis@novalis.org>
To: Ben Peart <benpeart@microsoft.com>, git@vger.kernel.org
Cc: prohaska@zib.de, gitster@pobox.com, tboegi@web.de,
sunshine@sunshineco.com
Subject: Re: [PATCH v1] name-hash: properly fold directory names in adjust_dirname_case()
Date: Wed, 07 Feb 2018 20:02:31 -0500 [thread overview]
Message-ID: <1518051751.15704.476.camel@novalis.org> (raw)
In-Reply-To: <20180208004156.36224-1-benpeart@microsoft.com>
On Wed, 2018-02-07 at 19:41 -0500, Ben Peart wrote:
> Correct the pointer arithmetic in adjust_dirname_case() so that it
> calls
> find_dir_entry() with the correct string length. Previously passing
> in
> "dir1/foo" would pass a length of 6 instead of the correct 4. This
> resulted in
> find_dir_entry() never finding the entry and so the subsequent memcpy
> that would
> fold the name to the version with the correct case never executed.
>
> Add a test to validate the corrected behavior with name folding of
> directories.
Looks good to me.
next prev parent reply other threads:[~2018-02-08 1:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 0:41 [PATCH v1] name-hash: properly fold directory names in adjust_dirname_case() Ben Peart
2018-02-08 1:02 ` David Turner [this message]
2018-02-08 17:21 ` Torsten Bögershausen
2018-02-08 17:45 ` Ben Peart
2018-02-08 18:24 ` Junio C Hamano
2018-02-08 18:20 ` Junio C Hamano
2018-02-08 19:23 ` [PATCH v2] " Ben Peart
2018-02-09 5:43 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518051751.15704.476.camel@novalis.org \
--to=novalis@novalis.org \
--cc=benpeart@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=prohaska@zib.de \
--cc=sunshine@sunshineco.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).