From: Xavier Maillard <zedek@gnu.org>
To: git@vger.kernel.org
Cc: julliard@winehq.org
Subject: [PATCH 7/7] Remove byte-compiler warnings
Date: Sat, 03 Mar 2007 11:20:46 +0100 [thread overview]
Message-ID: <15326.1172917246@localhost> (raw)
* emacs/git-blame.el: Do not load cl at run-time. Added several defvar
to silent byte-compiler.
Interactive form in git-reblame was not correct, fixed that.
Signed-off-by: Xavier Maillard <zedek@gnu.org>
---
contrib/emacs/git-blame.el | 16 ++++++++++++++--
1 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el
index 64ad50b..ce029ad 100644
--- a/contrib/emacs/git-blame.el
+++ b/contrib/emacs/git-blame.el
@@ -77,7 +77,8 @@
;;
;;; Code:
-(require 'cl) ; to use `push', `pop'
+(eval-when-compile
+ (require 'cl)) ; to use `push', `pop'
(defun color-scale (l)
(let* ((colors ())
@@ -127,11 +128,22 @@
(defvar git-blame-mode nil)
(make-variable-buffer-local 'git-blame-mode)
+
+(defvar git-blame-current nil)
+(make-variable-buffer-local 'git-blame-current)
+
+(defvar git-blame-file nil)
+(make-variable-buffer-local 'git-blame-file)
+
+(defvar git-blame-colors nil)
+(make-variable-buffer-local 'git-blame-colors)
+
(unless (assq 'git-blame-mode minor-mode-alist)
(setq minor-mode-alist
(cons (list 'git-blame-mode " blame")
minor-mode-alist)))
+
;;;###autoload
(defun git-blame-mode (&optional arg)
"Minor mode for displaying Git blame"
@@ -157,9 +169,9 @@
;;;###autoload
(defun git-reblame ()
"Recalculate all blame information in the current buffer"
+ (interactive)
(unless git-blame-mode
(error "git-blame is not active"))
- (interactive)
(git-blame-cleanup)
(git-blame-run))
--
1.5.0
reply other threads:[~2007-03-03 10:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15326.1172917246@localhost \
--to=zedek@gnu.org \
--cc=git@vger.kernel.org \
--cc=julliard@winehq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).