Re: [PATCH v4 00/10] repack: fix geometric repacking with gitalternates

[Derrick Stolee <derrickstolee@github.com>]

On 4/14/2023 2:01 AM, Patrick Steinhardt wrote:
> Hi,
> 
> this is the fourth version of my patch series to fix geometric repacking
> with repositories connected to an alternate object database.
> 
> This version only addresses some issues with the tests, the actual logic
> remains untouched:
> 
>     - The test added in t7700-repack.sh that verifies that `--local`
>       causes us to disable generation of the bitmap index was failing in
>       the linux-TEST-vars CI job. This was because it sets
>       GIT_TEST_MULTI_PACK_INDEX=1, which causes us to disable the bitmap
>       logic in git-repack(1). I've fixed this failure by explicitly
>       overriding the environment variable like other tests in the same
>       file do.
> 
>     - I've converted path checks to use `test_path_is_missing` and
>       `test_path_is_file` instead of `test ! -f` and `test -f`.
> 
>     - I've fixed a typo in t7703-repack-geometric.sh and shifted code
>       around a bit to make the test more readable, following Derrick's
>       suggestion.

Thanks for these updates. I'm happy with v4.

-Stolee