From: ydirson@free.fr
To: git list <git@vger.kernel.org>
Subject: [BUG] gitk deals badly with --not
Date: Tue, 21 Jul 2015 11:38:37 +0200 (CEST) [thread overview]
Message-ID: <1545730766.15139362.1437471517806.JavaMail.root@zimbra39-e7.priv.proxad.net> (raw)
In-Reply-To: <1236236440.15093493.1437470465599.JavaMail.root@zimbra39-e7.priv.proxad.net>
When gitk is run with "<some refs> --not <some other refs>" args, things work fine until one tries to modify the view.
There it considers "--not" to be an extra git-log argument on its own, and groups the negative refs together with the
positive refs, which naturally gives completely wrong results.
Not sure what the best course of action would be to fix that:
* add negative refs the extra args could be an option, since those are added last to the commandline, but then the
"edit" dialog becomes a bit strange, with refs listed at both ends of it
* add a dedicated field for negative refs
* convert them to the ^ref syntax
Either of those last 2 solution raise the concern of convertion between ^ and --not: in the case where we add a dedicated
field, would there be any reason not to move ^refs to this field instead ?
parent reply other threads:[~2015-07-21 9:39 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1236236440.15093493.1437470465599.JavaMail.root@zimbra39-e7.priv.proxad.net>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545730766.15139362.1437471517806.JavaMail.root@zimbra39-e7.priv.proxad.net \
--to=ydirson@free.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).