git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [BUG] gitk deals badly with --not
       [not found] <1236236440.15093493.1437470465599.JavaMail.root@zimbra39-e7.priv.proxad.net>
@ 2015-07-21  9:38 ` ydirson
  0 siblings, 0 replies; only message in thread
From: ydirson @ 2015-07-21  9:38 UTC (permalink / raw)
  To: git list

When gitk is run with "<some refs> --not <some other refs>" args, things work fine until one tries to modify the view.
There it considers "--not" to be an extra git-log argument on its own, and groups the negative refs together with the
positive refs, which naturally gives completely wrong results.

Not sure what the best course of action would be to fix that:
* add negative refs the extra args could be an option, since those are added last to the commandline, but then the
  "edit" dialog becomes a bit strange, with refs listed at both ends of it
* add a dedicated field for negative refs
* convert them to the ^ref syntax

Either of those last 2 solution raise the concern of convertion between ^ and --not: in the case where we add a dedicated
field, would there be any reason not to move ^refs to this field instead ?

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-07-21  9:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1236236440.15093493.1437470465599.JavaMail.root@zimbra39-e7.priv.proxad.net>
2015-07-21  9:38 ` [BUG] gitk deals badly with --not ydirson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).