* [PATCH] editorconfig: add .bash extension
@ 2025-03-02 20:54 David Mandelberg
2025-03-03 16:40 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: David Mandelberg @ 2025-03-02 20:54 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, brian m. carlson
Both files in the command below appear to be indented with tabs, and I'd
expect .bash files to have roughly the same style as .sh files.
$ find . -name \*.bash
./contrib/completion/git-completion.bash
./ci/check-directional-formatting.bash
Signed-off-by: David Mandelberg <david@mandelberg.org>
---
.editorconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.editorconfig b/.editorconfig
index a3c578a43c..2d3929b591 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -4,7 +4,7 @@ insert_final_newline = true
# The settings for C (*.c and *.h) files are mirrored in .clang-format. Keep
# them in sync.
-[{*.{c,h,sh,perl,pl,pm,txt,adoc},config.mak.*,Makefile}]
+[{*.{c,h,sh,bash,perl,pl,pm,txt,adoc},config.mak.*,Makefile}]
indent_style = tab
tab_width = 8
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] editorconfig: add .bash extension
2025-03-02 20:54 [PATCH] editorconfig: add .bash extension David Mandelberg
@ 2025-03-03 16:40 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2025-03-03 16:40 UTC (permalink / raw)
To: David Mandelberg; +Cc: git, brian m. carlson
David Mandelberg <david@mandelberg.org> writes:
> Both files in the command below appear to be indented with tabs, and I'd
> expect .bash files to have roughly the same style as .sh files.
>
> $ find . -name \*.bash
> ./contrib/completion/git-completion.bash
> ./ci/check-directional-formatting.bash
>
> Signed-off-by: David Mandelberg <david@mandelberg.org>
> ---
> .editorconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I love these obviously correct additions ;-)
Thanks.
> diff --git a/.editorconfig b/.editorconfig
> index a3c578a43c..2d3929b591 100644
> --- a/.editorconfig
> +++ b/.editorconfig
> @@ -4,7 +4,7 @@ insert_final_newline = true
>
> # The settings for C (*.c and *.h) files are mirrored in .clang-format. Keep
> # them in sync.
> -[{*.{c,h,sh,perl,pl,pm,txt,adoc},config.mak.*,Makefile}]
> +[{*.{c,h,sh,bash,perl,pl,pm,txt,adoc},config.mak.*,Makefile}]
> indent_style = tab
> tab_width = 8
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-03 16:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-02 20:54 [PATCH] editorconfig: add .bash extension David Mandelberg
2025-03-03 16:40 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).