From: Ben Knoble <ben.knoble@gmail.com>
To: Chris Down <chris@chrisdown.name>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
kernel-team@fb.com
Subject: Re: [PATCH] commit: Add commit.signoff configuration option
Date: Fri, 16 May 2025 07:50:07 -0400 [thread overview]
Message-ID: <167ABBF2-8DFB-4F1B-B5AA-93024FE8CA9C@gmail.com> (raw)
In-Reply-To: <aCTI7VjK5QMht3ws@chrisdown.name>
> Le 14 mai 2025 à 12:46, Chris Down <chris@chrisdown.name> a écrit :
>
> I understand where people are coming from for sure, but I think the conversation has moved on beyond many of those points, right? For example, some of the objections are about format.signoff in 2006, but we merged that into the tree since 2009 in commit 1d1876e9300c ("Add configuration variable for sign-off to format-patch").
Just in case it wasn’t clear: I think the patch is reasonable ;) I only meant that Junio had provided some background material that should probably be addressed, and now you have. Thanks!
next prev parent reply other threads:[~2025-05-16 11:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 12:20 [PATCH] commit: Add commit.signoff configuration option Chris Down
2025-05-13 13:12 ` Kristoffer Haugsbakk
2025-05-13 21:09 ` D. Ben Knoble
2025-05-14 16:46 ` Chris Down
2025-05-15 0:17 ` Junio C Hamano
2025-05-15 13:22 ` Chris Down
2025-05-16 13:09 ` Junio C Hamano
2025-05-16 15:04 ` Chris Down
2025-06-03 6:54 ` Chris Down
2025-06-04 13:32 ` Junio C Hamano
2025-06-05 1:46 ` Collin Funk
2025-06-09 4:24 ` Chris Down
2025-05-16 11:50 ` Ben Knoble [this message]
2025-05-16 14:28 ` Chris Down
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167ABBF2-8DFB-4F1B-B5AA-93024FE8CA9C@gmail.com \
--to=ben.knoble@gmail.com \
--cc=chris@chrisdown.name \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).