From: Paul Mackerras <paulus@samba.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: gitk (was Re: Linux v2.6.12-rc6)
Date: Fri, 10 Jun 2005 20:57:45 +1000 [thread overview]
Message-ID: <17065.29225.943521.738481@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0506081608450.2286@ppc970.osdl.org>
Linus Torvalds writes:
> and it would be cool if the "filename list" panel on the right side
> colorized the names by these things (only three cases - leave the "not
> touched" files off entirely, of course).
Hmmm. How about this: each parent is given a color, and the file
names are colored according to which parent they differ in. If a file
differs in more than one parent it gets listed more than once in the
colors for the parents in which it differs, with those entries being
consecutive in the list.
If instead I list the file once in yet another color, I don't see how
to make it intuitively obvious that that's what the color means, and I
get a combinatorial explosion in the number of colors required as the
number of parents grows (I would potentially need 2^n - 1 colors for n
parents).
> Also, it should actually possible to do a diff for these things with just
> doing a "diff3" on the two parents and on the merge result (diff3 normally
> expects the "original", but hey, the "original" might as well be the
> result), and thus color a merge file by whether the lines came from one
> side or the other or both (or neither, which would be a manual merge
> fixup).
I already have code in dirdiff to display n-way diffs in a single
window, so it's certainly doable. I think I will do it a little
differently in this case, though, because the final result has a
special status. If I color lines according to which parent(s) they
are present in and then have some other way to show which version was
chosen (maybe a black box around those lines? or a little tick (check
mark) or cross icon at the left hand edge of the line?) I think that
should be pretty clear. (I'll need another color for the cases where
the result is different to all of the parents, of course.)
Sounds interesting. I'll have a look at it.
Paul.
prev parent reply other threads:[~2005-06-10 10:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.58.0506061104190.1876@ppc970.osdl.org>
[not found] ` <20050607130535.GD16602@harddisk-recovery.com>
[not found] ` <Pine.LNX.4.58.0506070820170.2286@ppc970.osdl.org>
[not found] ` <17062.21286.601768.751853@cargo.ozlabs.ibm.com>
2005-06-08 23:16 ` gitk (was Re: Linux v2.6.12-rc6) Linus Torvalds
2005-06-10 10:57 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17065.29225.943521.738481@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).