Git development
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: git@vger.kernel.org
Subject: problem with git-diff-tree -S
Date: Thu, 30 Jun 2005 22:48:44 +1000	[thread overview]
Message-ID: <17091.59948.453311.980846@cargo.ozlabs.ibm.com> (raw)

I'm trying to implement a find function in gitk that will find commits
where the patch includes a particular string, using git-diff-tree.
It's not doing what I expect - am I expecting the wrong thing, or is
there a bug in git-diff-tree?

As an example, take commit 92a582ed2757456ca9599f8b4ea2064f2154eb02,
"[IA64] sparse cleanup of TIOCA files".  If I put that ID in a file
called id and do:

git-diff-tree --stdin -p <id

the resulting patch includes the lines:

-uint64_t
+static uint64_t

+int sn_topology_open(struct inode *inode, struct file *file);
+int sn_topology_release(struct inode *inode, struct file *file);

+extern struct list_head tioca_list;

Now if I do:

git-diff-tree --stdin -r -s -Ssn_topology <id

I get the ID printed to stdout, but if I do:

git-diff-tree --stdin -r -s -Stioca <id

I get nothing on stdout, and similarly if I use "-Sstatic".  What's
going on?

Paul.

             reply	other threads:[~2005-06-30 12:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-30 12:48 Paul Mackerras [this message]
     [not found] ` <7vpsu33a6z.fsf@assigned-by-dhcp.cox.net>
     [not found]   ` <17092.26085.238125.715025@cargo.ozlabs.ibm.com>
     [not found]     ` <7v3bqz1mxx.fsf@assigned-by-dhcp.cox.net>
     [not found]       ` <17112.46727.581664.508076@cargo.ozlabs.ibm.com>
     [not found]         ` <7vy886e1ry.fsf@assigned-by-dhcp.cox.net>
2005-07-17  8:21           ` [PATCH] diffcore-pickaxe: switch to "counting" behaviour Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17091.59948.453311.980846@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox