From: Paul Mackerras <paulus@samba.org>
To: Yann Dirson <ydirson@altern.org>
Cc: GIT list <git@vger.kernel.org>
Subject: Re: [PATCH] Fix gitk this->selected diffs
Date: Mon, 28 Nov 2005 19:28:13 +1100 [thread overview]
Message-ID: <17290.49053.798223.402920@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20051127222929.GM3393@nowhere.earth>
Yann Dirson writes:
> This patch changes the two git-diff-tree calls to get the necessary
> two ids in this case. It does so by propagating a "singlecommit" flag
> through all functions involved via an additional argument.
Seems a bit ugly... Why can't we just make the ids list that we pass
around have either 1 or 2 elements instead? I'll have a closer look,
but assuming that works I think it'll be a lot cleaner.
Thanks,
Paul.
prev parent reply other threads:[~2005-11-28 9:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-27 22:29 [PATCH] Fix gitk this->selected diffs Yann Dirson
2005-11-28 8:28 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17290.49053.798223.402920@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=ydirson@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).