Git development
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: skimo@liacs.nl
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] gitk: add Update menu item.
Date: Thu, 1 Dec 2005 22:51:41 +1100	[thread overview]
Message-ID: <17294.58317.317337.145932@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20051129211551.GF8383MdfPADPa@greensroom.kotnet.org>

Sven Verdoolaege writes:

> Update will redraw the commits if any commits have been added to any
> of the selected heads.  The new commits appear on the top.

I put this in although I'm not completely happy with it (though it is
a good step in the right direction).

Why do we unset children and nchildren in the phase == updatecommits
case?  Wouldn't it give the same result if we set ncleft to nchildren
for each commit and then we didn't call updatechildren in
finishcommits?  I think that would end up simpler.

I tried removing some commits (using git reset --hard) and then doing
selecting update from the menu, and it redrew everything, but the
removed commits were still shown.

Also, what will happen if the user selects update while gitk is still
drawing the graph?  I think that will cause havoc.  At _best_ we'll
end up with a truncated list of commits AFAICS.  We need to make that
robust.

Paul.

  reply	other threads:[~2005-12-01 11:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-23 22:20 [PATCH] gitk: add Update menu item Sven Verdoolaege
2005-11-29 21:15 ` Sven Verdoolaege
2005-12-01 11:51   ` Paul Mackerras [this message]
2005-12-01 13:07     ` Sven Verdoolaege
2005-12-08  7:52       ` Alex Riesen
  -- strict thread matches above, loose matches on Subject: below --
2005-09-20 12:24 Sven Verdoolaege
2005-09-20 14:56 ` Sven Verdoolaege
2005-09-21 23:46 ` Paul Mackerras
2005-09-22 13:30   ` Sven Verdoolaege

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17294.58317.317337.145932@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=skimo@liacs.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox