* gitk patch display corner-case bug
@ 2006-02-18 23:36 Karl Hasselström
2006-02-19 11:06 ` Paul Mackerras
0 siblings, 1 reply; 3+ messages in thread
From: Karl Hasselström @ 2006-02-18 23:36 UTC (permalink / raw)
To: Paul Mackerras; +Cc: git
In a recently updated stgit tree,
$ git-diff 51cb39db\^ 51cb39db
diff --git a/templates/covermail.tmpl b/templates/covermail.tmpl
index 9789c9c..44cd19e 100644
--- a/templates/covermail.tmpl
+++ b/templates/covermail.tmpl
@@ -4,5 +4,5 @@ Date: %(date)s
%(endofheaders)s
The following series implements...
---
+--
Signature
That is, a trailing whitespace was added after the two dashes.
However, gitk displays this as
index 9789c9c..44cd19e 100644
@@ -2,7 +2,7 @@ From: %(maintainer)s
Subject: [PATCH%(version)s%(number)s] Series short description
Date: %(date)s
%(endofheaders)s
The following series implements...
+--
Signature
Totally correct except that it omitted the line consisting of only
three dashes.
--
Karl Hasselström, kha@treskal.com
www.treskal.com/kalle
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: gitk patch display corner-case bug
2006-02-18 23:36 gitk patch display corner-case bug Karl Hasselström
@ 2006-02-19 11:06 ` Paul Mackerras
2006-02-19 14:38 ` Karl Hasselström
0 siblings, 1 reply; 3+ messages in thread
From: Paul Mackerras @ 2006-02-19 11:06 UTC (permalink / raw)
To: Karl Hasselström; +Cc: git
Karl Hasselström writes:
> Totally correct except that it omitted the line consisting of only
> three dashes.
Could you check that the missing line is present in the output from
git-rev-list --header --parents --topo-order please?
Paul.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: gitk patch display corner-case bug
2006-02-19 11:06 ` Paul Mackerras
@ 2006-02-19 14:38 ` Karl Hasselström
0 siblings, 0 replies; 3+ messages in thread
From: Karl Hasselström @ 2006-02-19 14:38 UTC (permalink / raw)
To: Paul Mackerras; +Cc: git
On 2006-02-19 22:06:04 +1100, Paul Mackerras wrote:
> Karl Hasselström writes:
>
> > Totally correct except that it omitted the line consisting of only
> > three dashes.
>
> Could you check that the missing line is present in the output from
> git-rev-list --header --parents --topo-order please?
I'm not sure I follow you. The affected commit is listed first by
"git-rev-list --header --parents --topo-order 51cb39db", but that
commad doesn't show diffs, so the missing line is not there.
--
Karl Hasselström, kha@treskal.com
www.treskal.com/kalle
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-02-19 14:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-18 23:36 gitk patch display corner-case bug Karl Hasselström
2006-02-19 11:06 ` Paul Mackerras
2006-02-19 14:38 ` Karl Hasselström
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).