Git development
 help / color / mirror / Atom feed
From: Jason Riedy <ejr@EECS.Berkeley.EDU>
To: git@vger.kernel.org
Subject: [PATCH] Set _ALL_SOURCE for AIX, but avoid its struct list.
Date: Mon, 15 Jan 2007 17:34:49 -0800	[thread overview]
Message-ID: <17466.1168911289@lotus.CS.Berkeley.EDU> (raw)

AIX 5.3 seems to need _ALL_SOURCE for struct addrinfo, but that
introduces a struct list in grp.h.

Signed-off-by: Jason Riedy <ejr@cs.berkeley.edu>
---
  Also, the AIX iconv is insufficent.  All tests pass if I build
  GNU libiconv, but using AIX's fails in many conversion tests.
  If you build with NO_ICONV, all the conversion tests fail as
  well.  I'm not sure if that should be changed, or if NO_ICONV
  should be removed...

 git-compat-util.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/git-compat-util.h b/git-compat-util.h
index 8781e8e..cbad411 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -15,6 +15,7 @@
 #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */
 #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */
 #endif
+#define _ALL_SOURCE
 #define _GNU_SOURCE
 #define _BSD_SOURCE
 
@@ -45,7 +46,9 @@
 #include <arpa/inet.h>
 #include <netdb.h>
 #include <pwd.h>
+#undef _ALL_SOURCE /* AIX 5.3L defines a struct list with _ALL_SOURCE. */
 #include <grp.h>
+#define _ALL_SOURCE
 
 #ifndef NO_ICONV
 #include <iconv.h>
-- 
1.5.0.rc1.gf4b6c

             reply	other threads:[~2007-01-16  2:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-16  1:34 Jason Riedy [this message]
2007-01-16  3:11 ` [PATCH] Set _ALL_SOURCE for AIX, but avoid its struct list Junio C Hamano
2007-01-16  3:46   ` Jason Riedy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17466.1168911289@lotus.CS.Berkeley.EDU \
    --to=ejr@eecs.berkeley.edu \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox