From: Paul Mackerras <paulus@samba.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: git@vger.kernel.org
Subject: Re: lstat() call in rev-parse.c
Date: Tue, 25 Apr 2006 09:23:33 +1000 [thread overview]
Message-ID: <17485.24053.35997.868256@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0604230906370.3701@g5.osdl.org>
Linus Torvalds writes:
> So the rule is: if you don't give that "--", then we have to be able to
> confirm that the filenames are really files. Not a misspelled revision
> name, or a revision name that was correctly spelled, but for the wrong
> project, because you were in the wrong subdirectory ;)
OK, fair enough. In that case we need a better error message, so I
don't get people complaining that gitk can't show the history of files
that don't exist any more. How about something like:
Argument "foo" is ambiguous - revision name or file/directory name?
Please put "--" before the list of filenames.
I'll hack up a patch to this effect.
Paul.
next prev parent reply other threads:[~2006-04-24 23:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-23 12:03 lstat() call in rev-parse.c Paul Mackerras
2006-04-23 16:19 ` Linus Torvalds
2006-04-24 23:23 ` Paul Mackerras [this message]
2006-04-26 15:28 ` Matthias Lederhofer
2006-04-26 15:43 ` Linus Torvalds
2006-04-26 17:15 ` [PATCH] Fix filename verification when in a subdirectory Linus Torvalds
2006-04-26 18:05 ` Timo Hirvonen
2006-04-26 18:14 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17485.24053.35997.868256@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).