From: Paul Mackerras <paulus@samba.org>
To: Sergey Vlasov <vsu@altlinux.ru>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitk: Display commit messages with word wrap
Date: Mon, 15 May 2006 09:34:05 +1000 [thread overview]
Message-ID: <17511.48749.631725.358279@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20060514151456.GA18012@procyon.home>
Sergey Vlasov writes:
> Some people put very long strings into commit messages, which then
> become invisible in gitk (word wrapping in the commit details window is
> turned off, and there is no horizontal scroll bar). Enabling word wrap
> for just the commit message looks much better.
Well... you can scroll in any direction with mouse button 2, but ok...
> + $ctext insert end "\n" {}
Why are you adding the superfluous {} ?
> - set comment {}
> + set headers {}
Why are you changing the name here? Your commit description doesn't
address either of these points.
Paul.
next prev parent reply other threads:[~2006-05-14 23:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-14 15:14 [PATCH] gitk: Display commit messages with word wrap Sergey Vlasov
2006-05-14 23:30 ` Junio C Hamano
2006-05-15 15:07 ` Sergey Vlasov
2006-05-14 23:34 ` Paul Mackerras [this message]
2006-05-15 15:06 ` Sergey Vlasov
2006-05-15 15:13 ` [PATCH] gitk: Display commit messages with word wrap (try 2) Sergey Vlasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17511.48749.631725.358279@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=vsu@altlinux.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox