git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: git@vger.kernel.org, Junio C Hamano <junkio@cox.net>
Subject: Re: [PATCH] gitk: Fix nextfile() and add prevfile()
Date: Wed, 27 Sep 2006 10:15:45 +1000	[thread overview]
Message-ID: <17689.49841.913304.878599@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <873bae3b5x.fsf_-_@duaron.myhome.or.jp>

OGAWA Hirofumi writes:

> The current nextfile() jumps to last hunk, but I think this is not
> intention, probably, it's forgetting to add "break;". And this
> patch also adds prevfile(), it jumps to previous hunk.

I think your prevfile isn't quite right - I don't think it will do the
right thing if $loc is past the last entry in $difffilestart.  Don't
you want the "$ctext yview $prev" after the loop?

Paul.

  parent reply	other threads:[~2006-09-27  0:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-25 13:46 [PATCH] gitk: Fix nextfile() and more OGAWA Hirofumi
2006-09-26  5:24 ` Junio C Hamano
2006-09-26 15:19   ` OGAWA Hirofumi
2006-09-26 15:22   ` [PATCH] gitk: Fix nextfile() and add prevfile() OGAWA Hirofumi
2006-09-26 15:27     ` [PATCH] gitk: add some key-bind OGAWA Hirofumi
2006-09-27  0:15     ` Paul Mackerras [this message]
2006-09-27  3:32       ` [PATCH] gitk: Fix nextfile() and add prevfile() OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17689.49841.913304.878599@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=git@vger.kernel.org \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).