From: Paul Mackerras <paulus@samba.org>
To: Yann Dirson <ydirson@altern.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add to gitk an --argscmd flag to get the list of refs to draw at refresh time.
Date: Sun, 22 Jul 2007 22:24:55 +1000 [thread overview]
Message-ID: <18083.19607.236048.797818@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20070712220411.31743.83101.stgit@gandelf.nowhere.earth>
Yann Dirson writes:
> This new version causes the command to add its revs to the litteral
> ones from command-line instead of overriding them, and allows to
> edit the command in the view editor.
Is it actually useful to use both the --argscmd flag and some literal
revisions on the command line? Why would you use both?
Instead of the --argscmd flag, maybe we could have a convention that
an argument starting with "|" is a command to run rather than a
literal revision. Would that suit? It would seem to simplify the
patch by eliminating the requirement for an extra entry field, as well
as removing the need for the separate viewargscmd array.
> Disclaimer: I'm no tcl/tk expert, feel free to flame my style :)
There are a couple of things I think should be done differently, in
fact. :)
Paul.
next prev parent reply other threads:[~2007-07-22 12:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-12 22:04 [PATCH] Add to gitk an --argscmd flag to get the list of refs to draw at refresh time Yann Dirson
2007-07-22 12:24 ` Paul Mackerras [this message]
2007-07-22 15:49 ` Yann Dirson
-- strict thread matches above, loose matches on Subject: below --
2007-06-03 22:49 Yann Dirson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18083.19607.236048.797818@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=ydirson@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).