From: Paul Mackerras <paulus@samba.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Steffen Prohaska <prohaska@zib.de>
Subject: Re: [PATCH] gitk: add check for required tcl version >= 8.4
Date: Sat, 20 Oct 2007 21:19:11 +1000 [thread overview]
Message-ID: <18201.58415.361214.601377@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <7vlkaplsu1.fsf@gitster.siamese.dyndns.org>
Junio C Hamano writes:
> From: Steffen Prohaska <prohaska@zib.de>
> Date: Fri, 28 Sep 2007 22:57:22 +0200
>
> gitk requires tcl version >= 8.4 to work flawlessly. So let's
> check the tcl version and quit if it's too low.
>
> Signed-off-by: Steffen Prohaska <prohaska@zib.de>
> ---
>
> * I do not have a ready access to older tcl/tk myself, so I
> cannot judge if this is sensible or not. Just forwarding in
> case you missed it.
Thanks for the patch. I have put in something similar using the
package require command, and using show_error to display the error in
a window.
Paul.
next prev parent reply other threads:[~2007-10-20 11:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-29 9:32 [PATCH] gitk: add check for required tcl version >= 8.4 Junio C Hamano
2007-10-20 11:19 ` Paul Mackerras [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-09-27 17:00 Relating to some syntax error in the gitk script Brett Schwarz
2007-09-28 20:57 ` [PATCH] gitk: add check for required tcl version >= 8.4 Steffen Prohaska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18201.58415.361214.601377@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=prohaska@zib.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).