From: Paul Mackerras <paulus@samba.org>
To: Michele Ballabio <barra_cuda@katamail.com>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>,
pdmef@gmx.net
Subject: Re: [PATCH-resent] gitk: fix in procedure drawcommits
Date: Sun, 21 Oct 2007 13:01:20 +1000 [thread overview]
Message-ID: <18202.49408.264600.839673@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <200710201802.48111.barra_cuda@katamail.com>
Michele Ballabio writes:
> This commit (and many others) has two parents, but the two parents
> have the same hash. So gitk tries to unset the same variable twice,
> hence the error. At this point, the fix for gitk should be either to
> check if the parents have the same hash when reading the commit or
> avoiding to unset two times the same variable.
Actually, there is a commit like that in the kernel tree, and with
this clue, I have managed to reproduce the problem on the kernel tree
with the command
gitk v2.6.12-rc2..13e652800d1644dfedcd0d59ac95ef0beb7f3165
I have just pushed out a fix to my gitk.git tree.
Paul.
next prev parent reply other threads:[~2007-10-21 3:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 5:28 gitk patch collection pull request Shawn O. Pearce
2007-10-19 7:25 ` [PATCH resend again] gitk: Do not pick up file names of "copy from" lines Johannes Sixt
2007-10-19 7:32 ` Shawn O. Pearce
2007-10-19 8:05 ` Johannes Sixt
2007-10-19 8:14 ` Shawn O. Pearce
2007-10-19 11:05 ` gitk patch collection pull request Paul Mackerras
2007-10-20 3:10 ` Shawn O. Pearce
2007-10-20 11:12 ` Jonathan del Strother
2007-10-20 11:46 ` Paul Mackerras
2007-10-20 13:00 ` Jonathan del Strother
2007-10-20 15:32 ` Jan Hudec
2007-10-19 13:44 ` [PATCH-resent] gitk: fix in procedure drawcommits Michele Ballabio
2007-10-20 10:16 ` Paul Mackerras
2007-10-20 16:02 ` Michele Ballabio
2007-10-20 18:35 ` Jan Hudec
2007-10-21 3:01 ` Paul Mackerras [this message]
2007-10-21 12:12 ` Rocco Rutte
2007-10-19 19:31 ` gitk patch collection pull request Linus Torvalds
2007-10-20 4:45 ` Paul Mackerras
2007-10-20 4:51 ` Linus Torvalds
2007-10-23 0:20 ` Paul Mackerras
2007-10-23 19:17 ` Linus Torvalds
2007-10-23 23:37 ` Paul Mackerras
2007-10-23 23:51 ` Linus Torvalds
2007-10-24 0:17 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18202.49408.264600.839673@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=barra_cuda@katamail.com \
--cc=git@vger.kernel.org \
--cc=pdmef@gmx.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).