git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Bash <bash@genarts.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: GIT Mailing-list <git@vger.kernel.org>,
	Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Subject: Effectively navigating branch history (was: Re: [PATCH] config.c: Remove unused git_config_global() function)
Date: Tue, 31 May 2011 14:21:24 -0400 (EDT)	[thread overview]
Message-ID: <18203023.45200.1306866084905.JavaMail.root@mail.hq.genarts.com> (raw)
In-Reply-To: <7vy61miws5.fsf@alter.siamese.dyndns.org>

----- Original Message -----
> From: "Junio C Hamano" <gitster@pobox.com>
> Sent: Tuesday, May 31, 2011 1:51:06 PM
> Subject: Re: [PATCH] config.c: Remove unused git_config_global() function
> 
> > Commit 8f323c00 (drop support for GIT_CONFIG_NOGLOBAL, 15-03-2011)
> > removed the git_config_global() function, among other things, since
> > it is no longer required. Unfortunately, this function has since
> > been unintentionally restored; I suspect by merge commit 25b86e45
> > (Merge branch 'jk/maint-config-alias-fix' into next, 25-05-2011).
> 
> Yeah, I think it was 1f9a980636 which was a merge between fb674d7 and
> 73546c0. I just compared the output between these two:
> 
> $ git diff fb674d7...73546c0 -- config.c ;# what the topic did
> $ git diff fb674d7 1f9a980 -- config.c ;# what was merged

Junio - I'd like to take a chance to learn from a master here if you don't mind.  I often find myself wanting to do the "what the topic did" operation but once the branch is merged and deleted, I have difficulty finding useful SHAs to diff.

So in an attempt to educate myself, I tried to track down fb674d7 and 1f9a980 (and failed miserably).  I can easily find 8f323c00 using 'git log -S git_config_global', but conceptually I want to trace children of 8f323c00 to see where it merged, and that seems ... complicated.  Do you mind walking through your thought process on this problem?

Thanks!
Stephen

  reply	other threads:[~2011-05-31 18:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-31 17:23 [PATCH] config.c: Remove unused git_config_global() function Ramsay Jones
2011-05-31 17:51 ` Junio C Hamano
2011-05-31 18:21   ` Stephen Bash [this message]
2011-05-31 18:40     ` Effectively navigating branch history Junio C Hamano
2011-05-31 18:51       ` Stephen Bash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18203023.45200.1306866084905.JavaMail.root@mail.hq.genarts.com \
    --to=bash@genarts.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ramsay@ramsay1.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).