From: Paul Mackerras <paulus@samba.org>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <junkio@cox.net>
Subject: Re: gitk graph routing problem
Date: Wed, 12 Dec 2007 09:26:10 +1100 [thread overview]
Message-ID: <18271.3714.731136.272491@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20071104104618.GA3078@steel.home>
Alex Riesen writes:
> To reproduce, try running in git repo:
>
> gitk 02f630448e5d48e..06ea6ba9cf46ef5
>
> Than go some pages (around 5) forward. You should notice system load
> going up rapidly. Now try paging back - and graph starts stretching
> to the right, to the point nothing fits on the screen anymore.
I finally got back to look at this. The problem is not so much the
layout algorithm per se as the fact that I haven't worked out a good
way to pack lots of downward-pointing arrows in without using up
arbitrarily large amounts of horizontal space. You have managed to
find an example where just about every commit is a merge needing one
or more downward-pointing arrows.
Incidentally, gitk from the dev branch of my gitk.git repo does much
better on this example, since it is able to hoist the open-circle
(excluded) commits up to the row below their merge children, which
looks much nicer.
Paul.
next prev parent reply other threads:[~2007-12-11 23:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-04 10:46 gitk graph routing problem Alex Riesen
2007-11-04 21:47 ` Paul Mackerras
2007-11-04 23:14 ` Junio C Hamano
2007-11-05 0:53 ` Alex Riesen
2007-11-05 1:17 ` Alex Riesen
2007-11-05 1:19 ` Alex Riesen
2007-12-11 22:26 ` Paul Mackerras [this message]
2007-12-14 22:29 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18271.3714.731136.272491@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).