git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: gitk layout bug
Date: Mon, 21 Jan 2008 20:50:34 +1100	[thread overview]
Message-ID: <18324.27370.96611.769276@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <alpine.LFD.1.00.0801191740020.2957@woody.linux-foundation.org>

Linus Torvalds writes:

> In the current git repository, try this:
> 
> 	gitk origin/master..origin/pu
> 
> and it starts out looking ok.
> 
> But then scroll down a bit (say, press "PageDown" ten to twenty times), 
> and scroll up again, and now that thing is totally unusable.
> 
> Is it just me?

No, I have seen it occasionally (though not recently), but I've never
been able to trigger it when I had some time to debug it. :/

I'd be interested to know if you can trigger it with the "dev" branch
of gitk, too.  The dev branch doesn't use --topo-order or
--date-order, but instead does the topological sort itself, so the
cold-cache case is a lot faster (and the hot-cache case goes just as
fast as before).  And because I can now reorder the commits, I can put
each open-circle commit just after the last merge that has it as a
parent, which ends up looking much nicer too.

Paul.

  parent reply	other threads:[~2008-01-21  9:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-20  1:44 gitk layout bug Linus Torvalds
2008-01-20  1:50 ` Johannes Schindelin
2008-01-20 20:30 ` Alex Riesen
2008-01-21  9:50 ` Paul Mackerras [this message]
2008-01-21 10:13   ` Johannes Sixt
2008-01-21 19:08   ` Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18324.27370.96611.769276@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=git@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).