Git development
 help / color / mirror / Atom feed
From: Bill Lear <rael@zopyra.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: Possible kinder GIT-VERSION-GEN?
Date: Mon, 4 Feb 2008 16:32:10 -0600	[thread overview]
Message-ID: <18343.37482.618436.999319@lisa.zopyra.com> (raw)
In-Reply-To: <7vve54ids2.fsf@gitster.siamese.dyndns.org>

On Monday, February 4, 2008 at 13:59:25 (-0800) Junio C Hamano writes:
>Bill Lear <rael@zopyra.com> writes:
>
>> I have my home directory under git control, and I have a build
>> directory (not tracked by git) under my home directory into which I
>> untar files and then in which I build things, including git.
>
>Let me make sure I understand you by rephrasing.  You are
>extracting git tarball as an untracked subdirectory in an
>unrelated project, and GIT-VERSION-GEN misbehaves.  One such
>misbehaviour is that it adds -dirty.

Yes, that is correct.

>And I think you are right.  The -dirty suffix should be relative
>to the output of "git describe".  Version string derived from
>any other codepath should not get the suffix, simply because we
>do not even know if it is dirty.  In fact, we should not even
>attempt to run that diff-index to figure out if it is dirty.

Ok, I trust you know what you are talking about with git-describe.:-)


Bill

      reply	other threads:[~2008-02-04 22:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-04 20:28 Possible kinder GIT-VERSION-GEN? Bill Lear
2008-02-04 21:59 ` Junio C Hamano
2008-02-04 22:32   ` Bill Lear [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18343.37482.618436.999319@lisa.zopyra.com \
    --to=rael@zopyra.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox