From: Paul Mackerras <paulus@samba.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: Rewriting boundary parents when path-limiting
Date: Sun, 24 Feb 2008 12:55:48 +1100 [thread overview]
Message-ID: <18368.52900.408974.782802@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <alpine.LFD.1.00.0802190921460.7833@woody.linux-foundation.org>
Linus Torvalds writes:
> Quite frankly, I suspect it's not worth it, and maybe you just shouldn't
> do that optimization and limit the commits in other ways instead (ie you
> might try to limit them *numerically* instead of by using negative
> commits, and do one first run with the number of commits limited to <n>,
> and then if that wasn't enough to re-connect the trees, you do the whole
> thing)
OK. I have fixed the problem in gitk by making it do:
git rev-list --first-parent --max-count=1 $id -- paths...
for each id that it gets while updating that is a boundary commit, if
we are doing path limiting and the id is one that isn't in the graph.
If what we get back is a commit that is already in the graph, then we
use it instead. That seems to do what I want.
Currently gitk executes that git rev-list synchronously, but if that
causes noticeable pauses, it could be done asynchronously instead.
Paul.
prev parent reply other threads:[~2008-02-24 1:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-16 12:10 Rewriting boundary parents when path-limiting Paul Mackerras
2008-02-19 17:41 ` Linus Torvalds
2008-02-24 1:55 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18368.52900.408974.782802@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).