From: Paul Mackerras <paulus@samba.org>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Junio C Hamano <gitster@pobox.com>,
kaitanie@cc.helsinki.fi, newsletter@dirk.my1.cc,
git@vger.kernel.org
Subject: Re: [PATCH] gitk: Add horizontal scrollbar to the diff view
Date: Sat, 8 Mar 2008 16:41:10 +1100 [thread overview]
Message-ID: <18386.9974.50409.525039@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20080308015357.GU8410@spearce.org>
Shawn O. Pearce writes:
> git-gui does this scrollbar on-demand thing in its revision list meta-widget,
> which is lib/choose_rev.tcl. The procedure in question is this, and it gets
> installed as:
That's a nice idea, doing it in _sb_set. However, since the text
widget adjusts the horizontal scroll bar depending on what's visible,
that would mean the scroll bar would appear and disappear as you
scrolled vertically through the text, which would be disconcerting.
So for a text I think it's better to have the scrollbar there
permanently.
Also, I wonder if you could use pack forget instead of destroying the
scrollbar?
Paul.
next prev parent reply other threads:[~2008-03-08 5:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-05 22:51 [PATCH] gitk: Add horizontal scrollbar to the diff view Pekka Kaitaniemi
2008-03-06 6:18 ` Junio C Hamano
2008-03-06 10:30 ` Paul Mackerras
2008-03-06 11:53 ` Pekka Kaitaniemi
2008-03-08 1:53 ` Shawn O. Pearce
2008-03-08 5:41 ` Paul Mackerras [this message]
2008-03-08 5:51 ` Shawn O. Pearce
-- strict thread matches above, loose matches on Subject: below --
2008-03-08 12:27 Pekka Kaitaniemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18386.9974.50409.525039@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kaitanie@cc.helsinki.fi \
--cc=newsletter@dirk.my1.cc \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).