git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH] Simplify MSGFMT setting in Makefile
Date: Fri, 14 Mar 2008 15:44:15 +1100	[thread overview]
Message-ID: <18394.671.630499.836160@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <7vr6eg7bn3.fsf_-_@gitster.siamese.dyndns.org>

Junio C Hamano writes:

>  * I am planning to close 'master' for -rc1 by the end of this week, so
>    please plan to tell me to pull if you have accumulated changes,
>    thanks.

I have a few commits for you to pull, but I am about to push a patch
for gitk like the one you sent for git-gui, so I'll send you a pull
request when I've done that.  However, I found that in this line:

>  else
>  	MSGFMT ?= msgfmt
> -	ifeq ($(shell $(MSGFMT) >/dev/null 2>&1 || echo $$?),127)
> +	ifneq ($(shell $(MSGFMT) --tcl -l C -d . /dev/null 2>/dev/null; echo $?),0)

I had to put "echo $$?" for it to work rather than "echo $?".

Paul.

  parent reply	other threads:[~2008-03-14  4:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21 23:53 msgmft segfaulting on tiger Martin Langhoff
2008-02-21 23:59 ` Martin Langhoff
2008-02-22  6:58   ` Shawn O. Pearce
2008-02-22 17:57     ` Martin Langhoff
2008-02-27 18:18       ` Gabriel Saldaña
2008-02-27 18:26         ` Johannes Schindelin
2008-02-27 18:42           ` Gabriel Saldaña
2008-02-27 22:04             ` Johannes Schindelin
2008-02-27 22:14               ` Junio C Hamano
2008-02-28  0:32                 ` Shawn O. Pearce
2008-03-04  7:02                   ` msgmft segfaulting on ubuntu gutsy (clean) Gabriel Saldaña
2008-03-04  7:07                     ` Shawn O. Pearce
2008-02-28 18:40                 ` msgmft segfaulting on tiger Gabriel Saldaña
2008-03-05  7:19                   ` Shawn O. Pearce
2008-03-06  8:40                     ` Junio C Hamano
2008-03-12  5:29                       ` [PATCH] Simplify MSGFMT setting in Makefile Junio C Hamano
2008-03-12  5:51                         ` Shawn O. Pearce
2008-03-12 10:19                         ` Charles Bailey
2008-03-14  4:44                         ` Paul Mackerras [this message]
2008-03-14  4:50                           ` Junio C Hamano
2008-03-14 13:07                           ` Andreas Ericsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18394.671.630499.836160@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).