From: Paul Mackerras <paulus@samba.org>
To: "Eric Raible" <raible@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: gitk: synchronize highlighting in file view for 'f'&'b' commands
Date: Fri, 2 May 2008 22:49:41 +1000 [thread overview]
Message-ID: <18459.3557.603906.871664@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <279b37b20803171300v748b5d23rcc5c0e534429d1be@mail.gmail.com>
Eric Raible writes:
> Previously, 'b', backspace, and delete all did the same thing.
> This changes 'b' to perform the inverse of 'f'. And both of
> them now highlight the filename of the currently diff.
OK, but...
> + set file [regsub -- "-* (.*?) -*" [$ctext get $loc "$loc lineend"] "\\1"]
> + set cline [$cflist search -regexp [subst {^$file$}] 0.0]
This seems to be working out the index of the line we want to
highlight in the file list, but both the callers of highlightfile can
supply that info much more easily by incrementing a count as they go
through $difffilestart, as far as I can tell.
Paul.
next prev parent reply other threads:[~2008-05-02 12:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-17 20:00 gitk: synchronize highlighting in file view for 'f'&'b' commands Eric Raible
2008-05-02 12:49 ` Paul Mackerras [this message]
2008-05-02 18:45 ` Eric Raible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18459.3557.603906.871664@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=raible@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).