From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Subject: Re: [PATCH 4/3] bisect: use a detached HEAD to bisect Date: Mon, 26 May 2008 10:15:20 +1000 Message-ID: <18490.280.325614.480038@cargo.ozlabs.ibm.com> References: <20080523012857.acce6457.chriscool@tuxfamily.org> <7v3ao9twfa.fsf@gitster.siamese.dyndns.org> <18487.62245.59892.442935@cargo.ozlabs.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Junio C Hamano , Christian Couder , Johannes Schindelin , Git Mailing List To: Linus Torvalds X-From: git-owner@vger.kernel.org Mon May 26 02:16:53 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1K0QOR-0004KM-TM for gcvg-git-2@gmane.org; Mon, 26 May 2008 02:16:52 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751627AbYEZAPc (ORCPT ); Sun, 25 May 2008 20:15:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751529AbYEZAPc (ORCPT ); Sun, 25 May 2008 20:15:32 -0400 Received: from ozlabs.org ([203.10.76.45]:51390 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751415AbYEZAPb (ORCPT ); Sun, 25 May 2008 20:15:31 -0400 Received: by ozlabs.org (Postfix, from userid 1003) id 1F86DDDF04; Mon, 26 May 2008 10:15:29 +1000 (EST) In-Reply-To: X-Mailer: VM 7.19 under Emacs 22.1.1 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Linus Torvalds writes: > Of course, _usually_ it's just the top commit, and it's obvious that way > which one is the checked-out one, but if you do "gitk --all" or just > generally have multiple branches, right now it's hard to see what commit > is the checked-out one, regardless of whether it's detached or not. If it's not detached, the branch name is in bold, but evidently that's either not intuitive or not sufficiently distinct... > I think "HEAD" in a green box would solve that too, but on the other hand, > we have a *lot* of boxes already. For people who mainly just track another > repo, you already have one box saying "master", and another one saying > "remotes/origin/master", and adding yet *another* box saying HEAD that > just points to the same commit will work, but do we really want that? > > I actually like the red circle for "Local uncommitted changes". Maybe we > can use a similar visual clue for "currently checked out". You already > picked green for the "added to the index" case, so we have the three > primary RGB colors already used, but we could make it just be a deep > yellow. > > Of course, maybe people hate lots of colos already, and something more > akin to the text background thing that we use for the selected commit > would be better. > > I dunno. There's so many options. > > Here's a "make it yellow" patch. Thanks. I have checked in something similar, that also handles the cases where you update the graph and the head has moved, and when you do a checkout or reset using the gitk menus. Paul.