From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
To: Tanay Abhra <tanayabh@gmail.com>
Cc: git@vger.kernel.org, Ramkumar Ramachandra <artagnon@gmail.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v10 3/4] add `config_set` API for caching config-like files
Date: Fri, 18 Jul 2014 11:40:07 +0200 (CEST) [thread overview]
Message-ID: <1849775492.2606791.1405676407530.JavaMail.zimbra@imag.fr> (raw)
In-Reply-To: <1405675142-20300-4-git-send-email-tanayabh@gmail.com>
----- Original Message -----
> Documentation/technical/api-config.txt | 137 +++++++++++++++++
> cache.h | 30 ++++
> config.c | 263
> +++++++++++++++++++++++++++++++++
> 3 files changed, 430 insertions(+)
I think the added call to git_config_clear() I proposed yesterday in setup_git_directory_gently_1 should be part of this patch (with the associated comment), just like this call:
> @@ -1707,6 +1967,9 @@ int git_config_set_multivar_in_file(const char
> *config_filename,
> lock = NULL;
> ret = 0;
>
> + /* Invalidate the config cache */
> + git_config_clear();
> +
> out_free:
> if (lock)
> rollback_lock_file(lock);
I have limited access to my email and no way to apply the patches today, so I can't do a detailed review. But other than the remark above, I guess the patch series is now all right and ready to cook in pu.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2014-07-18 9:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 9:18 [PATCH v10 0/4] git config cache & special querying api utilizing the cache Tanay Abhra
2014-07-18 9:18 ` [PATCH v10 1/4] string-list: add string_list initializer helper function Tanay Abhra
2014-07-18 17:15 ` Junio C Hamano
2014-07-18 9:19 ` [PATCH v10 2/4] replace memset with string-list initializers Tanay Abhra
2014-07-18 9:19 ` [PATCH v10 3/4] add `config_set` API for caching config-like files Tanay Abhra
2014-07-18 9:40 ` Matthieu Moy [this message]
2014-07-18 9:52 ` Tanay Abhra
2014-07-18 10:03 ` Matthieu Moy
2014-07-18 9:19 ` [PATCH v10 4/4] test-config: add tests for the config_set API Tanay Abhra
2014-07-18 17:01 ` Junio C Hamano
2014-07-18 21:52 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1849775492.2606791.1405676407530.JavaMail.zimbra@imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tanayabh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).