git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Alexander Gavrilov <angavrilov@gmail.com>
Cc: Christian Jaeger <christian@jaeger.mine.nu>, git@vger.kernel.org
Subject: Re: [PATCH (GITK BUGFIX)] gitk: Allow safely calling nukefile from a run queue handler.
Date: Mon, 11 Aug 2008 10:15:19 +1000	[thread overview]
Message-ID: <18591.33943.93992.177637@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <200808091441.50444.angavrilov@gmail.com>

Alexander Gavrilov writes:

> Originally dorunq assumed that the queue entry remained first
> in the queue after the script eval, and blindly removed it.
> However, if the handler calls nukefile, it may not be the
> case anymore, and a random queue entry gets dropped instead.
> 
> This patch makes dorunq remove the entry before calling the
> script, and adds a global variable to allow other functions
> to determine if they are called from within a dorunq handler.
> 
> Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>

Thanks, applied.

      parent reply	other threads:[~2008-08-11  0:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08 14:41 [BUG/PATCH] Revert "gitk: Arrange to kill diff-files & diff-index on quit" Christian Jaeger
2008-08-09  9:13 ` Alexander Gavrilov
2008-08-09 10:04   ` [PATCH] gitk: make diff and tree display work reliably again Christian Jaeger
2008-08-09 10:41     ` [PATCH (GITK BUGFIX)] gitk: Allow safely calling nukefile from a run queue handler Alexander Gavrilov
2008-08-09 11:24       ` Christian Jaeger
2008-08-11  1:02         ` Christian Jaeger
2008-08-11 20:44           ` Junio C Hamano
2008-08-11  0:15       ` Paul Mackerras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18591.33943.93992.177637@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=angavrilov@gmail.com \
    --cc=christian@jaeger.mine.nu \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).