From: Paul Mackerras <paulus@samba.org>
To: Alexander Gavrilov <angavrilov@gmail.com>
Cc: git@vger.kernel.org, Johannes Sixt <johannes.sixt@telecom.at>
Subject: Re: [PATCH (GITK) v2 3/4] gitk: Support filenames in the locale encoding.
Date: Fri, 10 Oct 2008 22:23:08 +1100 [thread overview]
Message-ID: <18671.15132.660369.249649@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <18671.15020.13951.943822@cargo.ozlabs.ibm.com>
I wrote:
> > @@ -6250,11 +6250,12 @@ proc gettreeline {gtf id} {
> > set line [string range $line 0 [expr {$i-1}]]
> > if {$diffids ne $nullid2 && [lindex $line 1] ne "blob"} continue
> > set sha1 [lindex $line 2]
> > - if {[string index $fname 0] eq "\""} {
> > - set fname [lindex $fname 0]
> > - }
> > lappend treeidlist($id) $sha1
> > }
> > + if {[string index $fname 0] eq "\""} {
> > + set fname [lindex $fname 0]
> > + }
>
> Concerning this part of the change, do we know whether git ls-files
> will quote filenames containing special characters or not?
A little experiment has convinced me that it does. So this part looks
OK.
Paul.
prev parent reply other threads:[~2008-10-10 11:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 11:00 [PATCH (GITK) v2 0/4] Encoding support in GUI Alexander Gavrilov
2008-09-30 11:00 ` [PATCH (GITK) v2 1/4] gitk: Port new encoding logic from git-gui Alexander Gavrilov
2008-09-30 11:00 ` [PATCH (GITK) v2 2/4] gitk: Implement file contents encoding support Alexander Gavrilov
2008-09-30 11:00 ` [PATCH (GITK) v2 3/4] gitk: Support filenames in the locale encoding Alexander Gavrilov
2008-09-30 11:00 ` [PATCH (GITK) v2 4/4] gitk: Implement batch lookup and caching of encoding attrs Alexander Gavrilov
2008-10-10 11:48 ` Paul Mackerras
2008-10-10 12:22 ` Alexander Gavrilov
2008-10-11 0:31 ` Paul Mackerras
2008-10-11 9:28 ` Alexander Gavrilov
2008-10-11 12:03 ` Paul Mackerras
2008-10-10 11:21 ` [PATCH (GITK) v2 3/4] gitk: Support filenames in the locale encoding Paul Mackerras
2008-10-10 11:23 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18671.15132.660369.249649@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=angavrilov@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.sixt@telecom.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).